[12gevmoller_sim] [JeffersonLab/remoll] a30c42: Repeat after me: I shall never throw away CXX flag...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/JeffersonLab/remoll
  Commit: a30c4229576e8117bc71280755bc16d57d511f08
      https://github.com/JeffersonLab/remoll/commit/a30c4229576e8117bc71280755bc16d57d511f08
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-04-29 (Sat, 29 Apr 2017)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  Repeat after me: I shall never throw away CXX flags.

Geant4, when compiled on a C++11 compatible compiler, sets G4USE_STD11
and relies on it being set. Normally no big deal since C++11 is backward
compatible with C++, so whatever worked when G4USE_STD11 was unset will
just continue work with G4USE_STD11 set. Exception: those cases where
the build process creates differently named files/functions. In particular
the G4MTHepRandom vs G4HepRandom classes for multithreaded PRNG.

By throwing away G4USE_STD11 in our CMakeLists.txt we ended up, at the
linking stage, trying to use G4MTHepRandom when we actually need G4HepRandom,
in some cases, when using a Geant4 installation with C++11 support and
multithreading support.


  Commit: 7b4bd9752b5d7534ab670a3781445fd548434ab9
      https://github.com/JeffersonLab/remoll/commit/7b4bd9752b5d7534ab670a3781445fd548434ab9
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-04-29 (Sat, 29 Apr 2017)

  Changed paths:
    M src/remollMultScatt.cc

  Log Message:
  -----------
  drand48 (flat 0.0--1.0) changed to G4UniformRand

This may fix issue #20, in particular comment 3.


  Commit: 3ec50b136adfbb5d28872b49f86ac2b36df42b18
      https://github.com/JeffersonLab/remoll/commit/3ec50b136adfbb5d28872b49f86ac2b36df42b18
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-04-29 (Sat, 29 Apr 2017)

  Changed paths:
    M src/remollGenPion.cc

  Log Message:
  -----------
  Initialize pion type to pi- in remollGenPion


  Commit: bad4e1bead4cf77015afcc39ba1ef902af53d9aa
      https://github.com/JeffersonLab/remoll/commit/bad4e1bead4cf77015afcc39ba1ef902af53d9aa
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-04-29 (Sat, 29 Apr 2017)

  Changed paths:
    M remoll.cc

  Log Message:
  -----------
  Small change to running time calculation.

The placement at the start of remoll.cc made it confusing because
immediately afterward the time is used to determine the random seed.
Also the placement of double at the end was incorrect: need to turn the
ints into doubles before division, not after division.


  Commit: 5b8fecdfd50bc085fd9a0ead0d1f61bc7bcd9555
      https://github.com/JeffersonLab/remoll/commit/5b8fecdfd50bc085fd9a0ead0d1f61bc7bcd9555
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-04-29 (Sat, 29 Apr 2017)

  Changed paths:
    M include/remollMessenger.hh
    M src/remollMessenger.cc

  Log Message:
  -----------
  Move G4VModularPhysicsList include into source file


  Commit: 302e903f3502b6a8c9793f01f745562e7169706f
      https://github.com/JeffersonLab/remoll/commit/302e903f3502b6a8c9793f01f745562e7169706f
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-04-29 (Sat, 29 Apr 2017)

  Changed paths:
    M include/remollVEventGen.hh

  Log Message:
  -----------
  Remove shadowing of variable ms as argument, not unit


  Commit: e19cfd64c7cff06bf79cb750836e4fbf3ffb4e44
      https://github.com/JeffersonLab/remoll/commit/e19cfd64c7cff06bf79cb750836e4fbf3ffb4e44
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-04-29 (Sat, 29 Apr 2017)

  Changed paths:
    M src/remollBeamTarget.cc
    M src/remollGenAl.cc
    M src/remollGenBeam.cc
    M src/remollGenFlat.cc
    M src/remollGenLUND.cc
    M src/remollGenMoller.cc
    M src/remollGenPion.cc
    M src/remollGenpElastic.cc
    M src/remollGenpInelastic.cc
    M src/remollMessenger.cc

  Log Message:
  -----------
  Moved from CLHEP::Random to G4Random

This change is a requirement for multithreading to work (but don't get
your hopes up). This fixes issue #20.

The #defines like G4RandFlat are available as of geant4 version 9.4.p02,
so don't try to compile with version of geant4 older than 10 years
(though there are plenty of other reasons to upgrade).


  Commit: 8f74c80b9e1dae9d11111a85db06e349b61e2210
      https://github.com/JeffersonLab/remoll/commit/8f74c80b9e1dae9d11111a85db06e349b61e2210
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-04-29 (Sat, 29 Apr 2017)

  Changed paths:
    M remoll.cc

  Log Message:
  -----------
  Type casts are really not needed for inherited classes


  Commit: 4d1a22ef6128d869a49f920c234c61d8bef4ef64
      https://github.com/JeffersonLab/remoll/commit/4d1a22ef6128d869a49f920c234c61d8bef4ef64
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-04-29 (Sat, 29 Apr 2017)

  Changed paths:
    M include/remollGenAl.hh
    M include/remollIO.hh
    M include/remollMessenger.hh
    M include/remollVEventGen.hh
    M src/remollBeamTarget.cc
    M src/remollDetectorConstruction.cc
    M src/remollGenAl.cc
    M src/remollMessenger.cc
    M src/remollMultScatt.cc

  Log Message:
  -----------
  Various header changes to streamline dependencies.


Compare: https://github.com/JeffersonLab/remoll/compare/8d9d226b6e06...4d1a22ef6128