[12gevmoller_sim] [JeffersonLab/remoll] 322348: Fix for TMD5-caused crash on ifarm (#50)

GitHub noreply at github.com
Fri Dec 15 13:49:30 EST 2017


  Branch: refs/heads/develop
  Home:   https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=HrjmcPs3oMf75VjyVl58UfETBLLlblUe7yeh9TLCECA&e= 
  Commit: 32234851c149ca1b8709aa2f47ec1b0012301afb
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_32234851c149ca1b8709aa2f47ec1b0012301afb&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=tXkC8ZpNLJBS-ii0RrjLnvDxO__26pKBMm-rgryhwJM&e= 
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-12-01 (Fri, 01 Dec 2017)

  Changed paths:
    M src/remollGlobalField.cc

  Log Message:
  -----------
  Fix for TMD5-caused crash on ifarm (#50)

* Fix for TMD5-caused crash on ifarm


  Commit: 6d2161a125501ebed3641f7c17675e34aeaa6791
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_6d2161a125501ebed3641f7c17675e34aeaa6791&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=Ki1D42d0kzMflHJGYvwmeKoKeU4TGjI2OZaoNcaHBWI&e= 
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    A macros/tests/test_seed.mac

  Log Message:
  -----------
  Test macro for /remoll/seed generation.

Note: To be moved to unit test upon merge to develop.


  Commit: 45d2aecdeb7a054a9fde5a77223685a8471c6aa6
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_45d2aecdeb7a054a9fde5a77223685a8471c6aa6&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=UTl4A2PK69sn-wjdS74VTdOBqAAvPTsudrIpO22hQbA&e= 
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M macros/tests/test_seed.mac

  Log Message:
  -----------
  More complete random seed test.

Creates 4 files. One with seed from urandom, two with same seed
set by /remoll/seed, third with different seed set by /remoll/seed.


  Commit: 30bd77a17a78ca7d618e3b1a23eae685dfd22897
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_30bd77a17a78ca7d618e3b1a23eae685dfd22897&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=CMUvJ3rO3t_6J5jyuT8hP8VCShIbdKa3ZqUkNMFWViM&e= 
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M include/remollRunData.hh

  Log Message:
  -----------
  Geant4 seeds are G4long which is typedef to long int.


  Commit: ea5843fec7d0e427ae7cb346c5f23baf4bf69bc7
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_ea5843fec7d0e427ae7cb346c5f23baf4bf69bc7&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=pSd9RB087ZOYnqqNPwpsvXhS_nghx4tvyd_CY2R4kJs&e= 
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M include/remollRun.hh
    M src/remollRun.cc

  Log Message:
  -----------
  New function remollRun::UpdateSeed to set remollRunData::fSeed

This avoids the need to call G4Random outside of remollRun. Not inside
remollRunData because that's a TObject class and dictionaries would
run into trouble with Randomize.hh includes.


  Commit: c3fea22ff93fbf5ffd508a6db710b3497ad1e0bf
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_c3fea22ff93fbf5ffd508a6db710b3497ad1e0bf&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=4yWz9h8jonoIGXFKokRqHNTacMAjGth0J4e-MNSyOso&e= 
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M src/remollMessenger.cc

  Log Message:
  -----------
  Geant4 seeds are G4long. Use remollRun::UpdateSeed().


  Commit: 683c75d0b741da5b4e5ecb0305739cb6be2d4525
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_683c75d0b741da5b4e5ecb0305739cb6be2d4525&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=MjNAYBUD9o27snrBLdHkqOOzX1arN_HmpWvXk9NYUVA&e= 
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M remoll.cc

  Log Message:
  -----------
  Use c++ ifstream for read urandom (no c-based fread)

Slightly different default seed logic:
- unless set explicitly, the seed is random
- default random seed is from urandom, unless that doesn't exist
- if urandom does not exist, random seed is from time and PID
- random seed set by /remoll/seed <int> or -r <int> command line
argument override the default random seed


  Commit: f5f71657bf4eac666b80dd2bec4c11082934cb4f
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_f5f71657bf4eac666b80dd2bec4c11082934cb4f&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=UfxK3-l_uh_Zaj91c0Ipacg36SVb6exC2Zd1rT6SqFE&e= 
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M remoll.cc

  Log Message:
  -----------
  Let G4Random pick random engine

This fixes issue #52. Test now succeeds as expected.


  Commit: cd7110a0842736747ef3e9c6f9da976392fdc63c
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_cd7110a0842736747ef3e9c6f9da976392fdc63c&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=l2eRKxdXcDcsaZRs0c6Iw6fij7aP_5DCBfWqE18pSC4&e= 
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M include/remollRun.hh
    M include/remollRunData.hh
    A macros/tests/test_seed.mac
    M remoll.cc
    M src/remollMessenger.cc
    M src/remollRun.cc

  Log Message:
  -----------
  Merge pull request #57 from JeffersonLab/hotfix-random-seed

Hotfix random seed


Compare: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_compare_73bd19732551...cd7110a08427&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=RIKCo8B5TKD_Tcwxkj5C85Du88FMILLlFBsLX_i8oZI&s=rCluKLOKlh3MbdluFqCUylpsdEOiAhDCgFvQgadtLBE&e= 


More information about the 12gevmoller_sim mailing list