[12gevmoller_sim] [JeffersonLab/remoll] 5a458d: Initialize fFile before calling InitializeTree bec...

Mon Feb 13 15:52:33 EST 2017

  Branch: refs/heads/new_io
  Home:   https://github.com/JeffersonLab/remoll
  Commit: 5a458daeabc4e3248b3ca796a412c021f59c9ba6
      https://github.com/JeffersonLab/remoll/commit/5a458daeabc4e3248b3ca796a412c021f59c9ba6
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M src/remollIO.cc

  Log Message:
  -----------
  Initialize fFile before calling InitializeTree because that function
has a conditional on fFile.

  Commit: 7f4455c94baec3830b08fb4daf1703aafb8213f4
      https://github.com/JeffersonLab/remoll/commit/7f4455c94baec3830b08fb4daf1703aafb8213f4
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M src/remollIO.cc

  Log Message:
  -----------
  Call InitializeTree after setting the filename to the default value.

  Commit: a194883aaf67baa14f720ce6fece699084e2f42c
      https://github.com/JeffersonLab/remoll/commit/a194883aaf67baa14f720ce6fece699084e2f42c
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M src/remollIO.cc

  Log Message:
  -----------
  When deleting an object, also set corresponding pointer to NULL. Especially when
later checking the pointer for object existence.

  Commit: a1a7ab9cdec39f3232dfae3954bfd19de811d518
      https://github.com/JeffersonLab/remoll/commit/a1a7ab9cdec39f3232dfae3954bfd19de811d518
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M src/remollOpticalPhysics.cc

  Log Message:
  -----------
  Fixed typo in Geant4 version determination. G4VERSION_NUMBER >= 1003
requires getting particle iterator differently.

  Commit: bcf7d9b5fcf374fd15b84546621d313d5029d316
      https://github.com/JeffersonLab/remoll/commit/bcf7d9b5fcf374fd15b84546621d313d5029d316
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remolltypes.hh

  Log Message:
  -----------
  New type remollEventParticle_t to replace fEvPart[_IO_MAXHIT] in remollIO

  Commit: 37abf0b93454cc5ba8faf205f647ddb50187d966
      https://github.com/JeffersonLab/remoll/commit/37abf0b93454cc5ba8faf205f647ddb50187d966
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollIO.hh

  Log Message:
  -----------
  Removed hit.n and sum.n class variables which are not used anymore.

  Commit: 8d2666f930af0816b6ed17db712c574e257cde58
      https://github.com/JeffersonLab/remoll/commit/8d2666f930af0816b6ed17db712c574e257cde58
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollEvent.hh
    M src/remollEvent.cc

  Log Message:
  -----------
  New getter for remollEventParticle_t in remollEvent.

  Commit: 8f6974cc47e8b23aea5edb8d5396eae5d9fdb159
      https://github.com/JeffersonLab/remoll/commit/8f6974cc47e8b23aea5edb8d5396eae5d9fdb159
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollLinkDef.h

  Log Message:
  -----------
  Add remollEventParticle_t to LinkDef so included in Dict.

  Commit: 0c5de8adfa90fb4b1970ddd4aa02eb77199ff31a
      https://github.com/JeffersonLab/remoll/commit/0c5de8adfa90fb4b1970ddd4aa02eb77199ff31a
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollIO.hh
    M src/remollIO.cc

  Log Message:
  -----------
  Note: Changes required to user code. ROOT code that used variables under
ev may need to change to part.

Changes fEvParts to vector<remollEventParticle_t> and write to tree
as "part[]." instead of previously "ev[].". This avoids requiring
user code to change references to ev.A and ev.xs, which are likely
used more often than the generated particles' kinematics.

  Commit: 56c8b3df7b64c2c1dfbd7463c27ef13bef23c7ae
      https://github.com/JeffersonLab/remoll/commit/56c8b3df7b64c2c1dfbd7463c27ef13bef23c7ae
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollIO.hh

  Log Message:
  -----------
  Removed MAXHIT limitations.

  Commit: 948b45d02e6cc93abc8e6f227c7f7a4c9505f957
      https://github.com/JeffersonLab/remoll/commit/948b45d02e6cc93abc8e6f227c7f7a4c9505f957
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollLinkDef.h
    M include/remolltypes.hh

  Log Message:
  -----------
  Added two types for IO: remollEvent_t and remollBeamTarget_t.

  Commit: 158213f1c0278b900b75bf31971d4e10adaf7c3e
      https://github.com/JeffersonLab/remoll/commit/158213f1c0278b900b75bf31971d4e10adaf7c3e
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollBeamTarget.hh
    M include/remollEvent.hh
    M include/remollGenericDetectorHit.hh
    M include/remollGenericDetectorSum.hh
    M include/remollIO.hh
    M src/remollEvent.cc
    M src/remollIO.cc

  Log Message:
  -----------
  Moved bm and ev variables to new IO mechanism based on new structs.

Renamed existing GetIO() functions (for hits) to be more descriptive.

  Commit: a90661caa8303e9ced577c9e953e0aee4deedaf8
      https://github.com/JeffersonLab/remoll/commit/a90661caa8303e9ced577c9e953e0aee4deedaf8
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    A include/remollPhysicalConstants.hh
    A include/remollSystemOfUnits.hh
    M include/remollglobs.hh

  Log Message:
  -----------
  Move additional remoll system of units and physical constants into
a separate header, which is still included through remollglobs.hh.

  Commit: 77eb11fd54a208d48d61ac30c14924d0c0c5e235
      https://github.com/JeffersonLab/remoll/commit/77eb11fd54a208d48d61ac30c14924d0c0c5e235
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  Explicitly add remolltypes.hh to CMakeLists to generate dicts,
since we're relying on implicit #include through remollRunData.hh
otherwise which is pretty fragile.

  Commit: 80832be4662114f2a4d87d250f6701707de4712d
      https://github.com/JeffersonLab/remoll/commit/80832be4662114f2a4d87d250f6701707de4712d
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollLinkDef.h

  Log Message:
  -----------
  Change to ifdef guard on LinkDef file to catch __CLING__ set by new
rootcling in ROOT v6.

  Commit: 80291711743fd3b9827367238434b7a20467299e
      https://github.com/JeffersonLab/remoll/commit/80291711743fd3b9827367238434b7a20467299e
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remolltypes.hh

  Log Message:
  -----------
  Include G4Types.hh through remolltypes.hh because it makes sense.
Guard against __CINT__ or __CLING__ compilation though.

  Commit: 263799895b24f60ecc8280973e82d19cdd732d29
      https://github.com/JeffersonLab/remoll/commit/263799895b24f60ecc8280973e82d19cdd732d29
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollLinkDef.h
    M include/remolltypes.hh

  Log Message:
  -----------
  New type remollUnits_t to store to ROOT tree for unit management.

  Commit: d73bcdbdbebeed5c7457f0887f4b901146b3b9a7
      https://github.com/JeffersonLab/remoll/commit/d73bcdbdbebeed5c7457f0887f4b901146b3b9a7
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollSystemOfUnits.hh

  Log Message:
  -----------
  Create new units in remoll namespace, but using remoll::ppb etc.

  Commit: 4be674fe34b56c32e73f2a60b2c1a035564fe868
      https://github.com/JeffersonLab/remoll/commit/4be674fe34b56c32e73f2a60b2c1a035564fe868
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    A src/remollSystemOfUnits.cc

  Log Message:
  -----------
  Constructor to assign CLHEP and remoll system of units to remollUnits_t
for storage in ROOT tree.

  Commit: f3a605112a77c67b6c82100290fbdeded34e396d
      https://github.com/JeffersonLab/remoll/commit/f3a605112a77c67b6c82100290fbdeded34e396d
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M include/remollIO.hh
    M src/remollIO.cc

  Log Message:
  -----------
  Create units branch with default units

These units can be used as for example
  T->Draw("hit.x/mm:hit.y/mm:hit.z/m")
to make units explicit in the ROOT Draw commands (and default axis
labels), while making clear what units are stored in the ROOT tree
(since they are now the default Geant4 units in the remoll system
of units).

  Commit: f72745f05f38e2bdb6d374d609780f5ebe65a5c6
      https://github.com/JeffersonLab/remoll/commit/f72745f05f38e2bdb6d374d609780f5ebe65a5c6
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M src/remollIO.cc

  Log Message:
  -----------
  Finally, renamed hit.collCut to collCut since otherwise not accessible.

Compare: https://github.com/JeffersonLab/remoll/compare/454797912dec...f72745f05f38