[12gevmoller_sim] [JeffersonLab/remoll] 99f2e6: Changed constants to quantities for better unit ma...

[GitHub]

  Branch: refs/heads/pion
  Home:   https://github.com/JeffersonLab/remoll
  Commit: 99f2e675fd7547e1464df43c5c248e45a2b3c38f
      https://github.com/JeffersonLab/remoll/commit/99f2e675fd7547e1464df43c5c248e45a2b3c38f
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M geometry_sculpt/pionDetectorLuciteSector.gdml

  Log Message:
  -----------
  Changed constants to quantities for better unit management.

Moved lucite upstream to account better for detector rotation.

Added more documentation on the variables that can be modified.


  Commit: 380af61abb26aa89da7f2fd9eec8d0abdc3bac4f
      https://github.com/JeffersonLab/remoll/commit/380af61abb26aa89da7f2fd9eec8d0abdc3bac4f
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M geometry_sculpt/pionDetectorLucite.gdml

  Log Message:
  -----------
  Allow for rotation of lucite and light guide (independently).

This replaces the implementation with <trd> with <trap> which does
not require bottom and top face to be centered on the same z axis.
Now, an angle can be specified to generate a mitered edge, i.e. /_/

The miter angle can be applied to the lucite planes (and the glue,
mylar and whole shebang), and a different miter angle to the light
guide and aluminum reflector etc.

The previous configuration can be obtained for both angles set to 0
(no miter on the lucite cuts).

Unfortunately geant4 restrictions prevent the lucity rotation from
working. Although the replicated volume of lucite planes does fill
the parent volume exactly, geant4 calculates N * shift and compares
this with the bounding box of the parent volume. For these rotated
trapezoids the bounding box is defined by the top and bottom edges
and clearly larger than N * shift. Upstream bug fix in progress.
This bug does currently restrict the miter angle on the lucite to
zero, since otherwise it failes at voxel creation. A local bug fix
is unlikely because G4SmartVoxelHeader is deep inside the geometry
management sector of geant4 and can't be locally inherited and
modified in remoll (the way we could modify G4GDMLParser).

Un-mitered rotations can still be applied with the angle in the parent
file pionDetectorLuciteSector.gdml. That rotates the whole lucite/
lightguide/PMT assembly.


  Commit: e6af7363c7f9c44372c441b5a69b0f24ad80d6f2
      https://github.com/JeffersonLab/remoll/commit/e6af7363c7f9c44372c441b5a69b0f24ad80d6f2
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M include/remollGenericDetectorHit.hh
    M include/remolltypes.hh
    M src/remollGenericDetector.cc
    M src/remollGenericDetectorHit.cc

  Log Message:
  -----------
  Merge branch 'pion' of github.com:JeffersonLab/remoll into pion


Compare: https://github.com/JeffersonLab/remoll/compare/a8a1acd852cf...e6af7363c7f9