[12gevmoller_sim] [JeffersonLab/remoll] c3152d: Fixing optical physics by demoting parallel world ...

[GitHub]

  Branch: refs/heads/develop
  Home:   https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll&d=DwIFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=GK1b88x9pcbYBkf6nRiEQafdrbE_dukiByIMAtQACgQ&s=I6Rt_ygU6-544zQPaBpi2jmOKdFN8fxdvw6er7zHSrs&e= 
  Commit: c3152d3e712c8b91c22d524c0c52764804575296
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_c3152d3e712c8b91c22d524c0c52764804575296&d=DwIFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=GK1b88x9pcbYBkf6nRiEQafdrbE_dukiByIMAtQACgQ&s=0iBITIgrWZzCeiIYSjwjhiQs2sMDNUM46IjnNd7Z4H0&e= 
  Author: Cameron Clarke <cameronc137 at gmail.com>
  Date:   2018-11-18 (Sun, 18 Nov 2018)

  Changed paths:
    M include/remollPhysicsList.hh
    M remoll.cc
    M src/remollDetectorConstruction.cc
    M src/remollPhysicsList.cc

  Log Message:
  -----------
  Fixing optical physics by demoting parallel world physics list to the same level (and adding appropriate macro commands) as the step limiter and optical physics lists.

This may not work, but I do not know how to test the parallel world in order to verify this bugfix other than that it definitely makes optical physics work again.


  Commit: f8889b72eb7061f4c7c067b6a96d8b235f9a6c89
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_f8889b72eb7061f4c7c067b6a96d8b235f9a6c89&d=DwIFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=GK1b88x9pcbYBkf6nRiEQafdrbE_dukiByIMAtQACgQ&s=WG-ZgcjRVoDXUPrajEIbSi6RCY4CeGwdbnbPgA8jiBs&e= 
  Author: Cameron Clarke <cameronc137 at gmail.com>
  Date:   2018-11-19 (Mon, 19 Nov 2018)

  Changed paths:
    M analysis/pe.cc
    M macros/pion/pion_optical_response.mac
    M macros/runexample.mac
    M macros/tests/unit/test_gen_external.mac

  Log Message:
  -----------
  Tested macro enabled parallel world

Added macro command to macros that depend on paralle world

BROKEN: The pion optical response script reads the output in parallel world detectors, but also uses optical physics - both cannot be set simultaneously (optical physics breaks when paralle world physics is enabled) - this needs to be fixed in the optical pion analysis, or it needs to be fixed in the physics list handling

Update to pe.cc coming along for the ride


  Commit: d0915ccf5551c96af69082ae87fcd6b156a94fc8
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_d0915ccf5551c96af69082ae87fcd6b156a94fc8&d=DwIFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=GK1b88x9pcbYBkf6nRiEQafdrbE_dukiByIMAtQACgQ&s=pMb69j_fhlY36IJEbATymkEEd4fgkzslFDs2VUgGoXA&e= 
  Author: Cameron Clarke <cameronc137 at gmail.com>
  Date:   2018-11-19 (Mon, 19 Nov 2018)

  Changed paths:
    M analysis/pe.cc
    M include/remollPhysicsList.hh
    M macros/pion/pion_optical_response.mac
    M macros/runexample.mac
    M macros/tests/unit/test_gen_external.mac
    M remoll.cc
    M src/remollDetectorConstruction.cc
    M src/remollPhysicsList.cc

  Log Message:
  -----------
  Merge pull request #163 from JeffersonLab/bugfix-opticalReflections-fix

Fixing optical physics by demoting parallel world physics list to the…


Compare: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_compare_b185ce7b60e4...d0915ccf5551&d=DwIFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=GK1b88x9pcbYBkf6nRiEQafdrbE_dukiByIMAtQACgQ&s=0Q0xy8ocTrnluMZMvtjvjKpSBgMvJYpRbhkxoJ3NJns&e= 
      **NOTE:** This service has been marked for deprecation: https://urldefense.proofpoint.com/v2/url?u=https-3A__developer.github.com_changes_2018-2D04-2D25-2Dgithub-2Dservices-2Ddeprecation_&d=DwIFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=3B3cpV8BW_CcRY44e0IgDNmqzlTXeeJsbWtRdt_HYCM&m=GK1b88x9pcbYBkf6nRiEQafdrbE_dukiByIMAtQACgQ&s=W19LxdVgSeHwB3iE1HhWRu9KKNOg2Yn8odOKDJQDbQ8&e= 

      Functionality will be removed from GitHub.com on January 31st, 2019.