[12gevmoller_sim] [JeffersonLab/remoll] 528faa: Use G4Rand instead of CLHEP::Rand

[Wouter Deconinck]

  Branch: refs/heads/enhancement-gen-tf1-strings
  Home:   https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cde9c6b77773646fe64d408d6b771407c%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636898094364987292&sdata=1CtOtpiy%2Fks9xXj5Lwn0tKTFdQG446sZw1lRR4XUeKU%3D&reserved=0
  Commit: 528faa19417684fafae98b0745eb501e78adf366
      https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F528faa19417684fafae98b0745eb501e78adf366&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cde9c6b77773646fe64d408d6b771407c%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636898094364997297&sdata=C8b%2FRsBe%2Fs1wGO5u5YYTSEalnI5dN%2FuaW%2F%2Bjt26YTMo%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-04-02 (Tue, 02 Apr 2019)

  Changed paths:
    M include/remollGenTF1.hh
    M src/remollGenTF1.cc

  Log Message:
  -----------
  Use G4Rand instead of CLHEP::Rand

With the move to MT support, the treatment of random numbers was
modified in geant4. One should not call the CLHEP::Rand functions but
instead use the G4Rand versions which are MT safe. This mainly affects
the G4Random seeding, but consistency is probably preferred here.

See e.g.
https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwiki.cern.ch%2Ftwiki%2Fbin%2Fview%2FGeant4%2FQuickMigrationGuideForGeant4V10%23Random_numbers&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cde9c6b77773646fe64d408d6b771407c%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636898094364997297&sdata=C%2BsPeRuLS%2BYMGtHj45vQT9eToMhn2eQQ4jTnqlYSoWA%3D&reserved=0.


  Commit: b20e8c00779616d3781a08c822ebfee259d68419
      https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2Fb20e8c00779616d3781a08c822ebfee259d68419&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cde9c6b77773646fe64d408d6b771407c%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636898094364997297&sdata=UL0MloV90c79HOjU9c%2BqVxANfIOfiDfS9SVuQ70yECs%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-04-02 (Tue, 02 Apr 2019)

  Changed paths:
    M src/remollGenTF1.cc

  Log Message:
  -----------
  Remove cerr output on standard operation


  Commit: 078a52b16813e2b483701bf3d6129e2a3ebebd29
      https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F078a52b16813e2b483701bf3d6129e2a3ebebd29&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cde9c6b77773646fe64d408d6b771407c%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636898094364997297&sdata=w8wRZ9yrNOLctgcyP0aBSEq5vB3G%2FTKb4OoyZJ4WlKI%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-04-02 (Tue, 02 Apr 2019)

  Changed paths:
    M include/remollGenTF1.hh
    M src/remollGenTF1.cc

  Log Message:
  -----------
  Avoid passing *new G4String

*new G4String introduced memory leaks since the pointer won't ever be
cleaned up. If the main reason is passing by reference, then this does
not present a sufficient performance gain since these are functions only
called during initialization, not during running.


Compare: https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcompare%2F528faa194176%255E...078a52b16813&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cde9c6b77773646fe64d408d6b771407c%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636898094364997297&sdata=mp%2BnUI2n%2Fsrgnm6vqx%2B7TExIrQ09Z5PJkeN1DlD%2F53M%3D&reserved=0