[12gevmoller_sim] [JeffersonLab/remoll] 1fe474: Create a DetType == all to save all hits (not opti...

[Wouter Deconinck]

  Branch: refs/heads/develop
  Home:   https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll&data=02%7C01%7C12gevmoller_sim%40jlab.org%7C881086ca81e74a2f32a408d69c313365%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636868132471243853&sdata=hQcP%2FR4UP%2Fw06%2BM%2FENUF7gMMP%2BcIHZSogn1khIvZjOo%3D&reserved=0
  Commit: 1fe474f82c184c1c282e4d64961f89e50165cd3d
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F1fe474f82c184c1c282e4d64961f89e50165cd3d&data=02%7C01%7C12gevmoller_sim%40jlab.org%7C881086ca81e74a2f32a408d69c313365%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636868132471243853&sdata=NTrxTxUyXf8BWcFsQa%2BfmmPezeJdlCmFtcH6ZDpgg2Q%3D&reserved=0
  Author: Wouter Deconinck <wdeconinck at wm.edu>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M geometry/upstreamDaughter_merged.gdml
    M include/remollGenericDetector.hh

  Log Message:
  -----------
  Create a DetType == all to save all hits (not optical photons, bah)

This is mainly a quick bugfix so @chandabindu can continue working


  Commit: 65e5c4cede2af341e41da078a0a137fd84508f54
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F65e5c4cede2af341e41da078a0a137fd84508f54&data=02%7C01%7C12gevmoller_sim%40jlab.org%7C881086ca81e74a2f32a408d69c313365%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636868132471253857&sdata=r%2BTngqY6jdQB53h00YwUvIWOObNAJG1oqjfqXUMq0B0%3D&reserved=0
  Author: chandabindu <chandabindu at gmail.com>
  Date:   2019-02-17 (Sun, 17 Feb 2019)

  Changed paths:
    M geometry/mollerMother_merged.gdml
    A geometry/subTargetRegion.gdml
    M geometry/upstreamDaughter_merged.gdml
    M macros/vis.mac
    M vis/vis.mac

  Log Message:
  -----------
  Update of target shielding, modification of beampipe (used for stopping two bounce photons) geomtry


  Commit: 3828ba7c4b85421b27d0d5197ea36ea3fb18bf56
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F3828ba7c4b85421b27d0d5197ea36ea3fb18bf56&data=02%7C01%7C12gevmoller_sim%40jlab.org%7C881086ca81e74a2f32a408d69c313365%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636868132471253857&sdata=5lMvcIJdIajl0qt1Whvqe0YhyZqevy9iRlwL5P2vTV0%3D&reserved=0
  Author: chandabindu <chandabindu at gmail.com>
  Date:   2019-02-17 (Sun, 17 Feb 2019)

  Changed paths:
    M geometry/hybridDaughter_merged.gdml
    M geometry/subTargetRegion.gdml

  Log Message:
  -----------
  Shielding geometry update for target chamber designed by Alan


  Commit: bc580f2d5deb43d0d95d48bdcbc21a1b100de413
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2Fbc580f2d5deb43d0d95d48bdcbc21a1b100de413&data=02%7C01%7C12gevmoller_sim%40jlab.org%7C881086ca81e74a2f32a408d69c313365%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636868132471253857&sdata=3oKshcV9O%2BNOVA72kr7WsW%2BROfOn5IRbosP4E54PuNw%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-02-18 (Mon, 18 Feb 2019)

  Changed paths:
    M include/remollGenericDetector.hh
    M macros/tests/unit/test_det_enable.mac

  Log Message:
  -----------
  Print out what a detector is sensitive to in /remoll/SD/print_all

Updated test case


  Commit: 752dd0e36090b2072e494c51ebaa8969e63d10f0
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F752dd0e36090b2072e494c51ebaa8969e63d10f0&data=02%7C01%7C12gevmoller_sim%40jlab.org%7C881086ca81e74a2f32a408d69c313365%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636868132471253857&sdata=Bfn0IXBvMUgolu9Cw16US7x5%2BEfTmHOhKDtkmW8xxCY%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-02-18 (Mon, 18 Feb 2019)

  Changed paths:
    M geometry/upstreamDaughter_merged.gdml
    M src/remollDetectorConstruction.cc

  Log Message:
  -----------
  Replace det type "all" with ability to specify >1 GDML DetType

This is a better solution than adding another label that essentially
does the same as what labels we already had. The reason why "all" was a
quick fix is because we overwrote every DetType with the last one when
reading the GDML file. I've reorganized how the GDML tags are read (yay
for c++ lambdas and automatics type deduction...)

@chandabindu I'm going to merge this back into develop. Can you first
let me know if it allows you to see all hits from both lowenergyneutrals
and secondaries?


  Commit: bdbebd683c44009a975cd69922a312654d3ab7c9
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2Fbdbebd683c44009a975cd69922a312654d3ab7c9&data=02%7C01%7C12gevmoller_sim%40jlab.org%7C881086ca81e74a2f32a408d69c313365%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636868132471253857&sdata=vEAuBNUwEvRameuXwj%2BzeBv6zAny3gb9fTiNvq4vt7o%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M include/remollDetectorConstruction.hh
    M src/remollDetectorConstruction.cc

  Log Message:
  -----------
  Fixed bug noticed by Sakib, pointer still at null

Took me way to long to fix this since I kept overlooking it...

Two new aux helper functions: HasAuxWithType and NextAuxWithType for use
in, for example (in a loop over volumes):
```
G4GDMLAuxListType list = (*iter).second;
if (HasAuxWithType(list,"SensDet")) { /* do something */ }
for (auto it_dettype  = NextAuxWithType(list.begin(), list.end(),
"DetType");
          it_dettype != list.end();
it_dettype  = NextAuxWithType(++it_dettype, list.end(),
"DetType")) { /* do something */ }
```


  Commit: edcfb446eac17c50534db329e7eda304c887b656
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2Fedcfb446eac17c50534db329e7eda304c887b656&data=02%7C01%7C12gevmoller_sim%40jlab.org%7C881086ca81e74a2f32a408d69c313365%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636868132471253857&sdata=tETlp30lGpv%2FQyTgW%2BJDCJl78Bh4T4G3iDNfgF9NYZ4%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M geometry/hybridDaughter_merged.gdml
    M geometry/mollerMother_merged.gdml
    A geometry/subTargetRegion.gdml
    M geometry/upstreamDaughter_merged.gdml
    M include/remollDetectorConstruction.hh
    M include/remollGenericDetector.hh
    M macros/tests/unit/test_det_enable.mac
    M macros/vis.mac
    M src/remollDetectorConstruction.cc
    M vis/vis.mac

  Log Message:
  -----------
  Merge pull request #197 from JeffersonLab/bugfix-save-all-hits

Merge bugfix to save all hits into develop. Now multiple detector type statements can be included in GDML without problems.


Compare: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcompare%2F4b8e0a88dcf9...edcfb446eac1&data=02%7C01%7C12gevmoller_sim%40jlab.org%7C881086ca81e74a2f32a408d69c313365%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636868132471253857&sdata=U%2FAzpPkDv372g%2FKDKNh91rDmIZd0OOjMOMTSCpoUii0%3D&reserved=0