[12gevmoller_sim] [JeffersonLab/remoll] 63acec: For optical photon that reach geom boundary, store...

Wouter Deconinck noreply at github.com
Thu Feb 28 19:38:23 EST 2019


  Branch: refs/heads/develop
  Home:   https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Ced25fe6855294141dd7808d69dde3649%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636869975060902875&sdata=wydVIanba940rcjCAYvtxmzCK2NCO3v6nnjziHetGbU%3D&reserved=0
  Commit: 63acecb13340e094c9dbaa4fad8947d120496fa1
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F63acecb13340e094c9dbaa4fad8947d120496fa1&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Ced25fe6855294141dd7808d69dde3649%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636869975060902875&sdata=dweKU%2F8r%2FxWtfzUYbMq84Xnj%2FhzmSwjd9564caISQRQ%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2018-08-01 (Wed, 01 Aug 2018)

  Changed paths:
    M src/remollGenericDetector.cc

  Log Message:
  -----------
  For optical photon that reach geom boundary, store post step point

This fixes #127.

Issues created? Maybe some.
- How do we want to store optical photon hits? Ideally none at all since
the only physical way to detect them is by absorption on a surface...
- This may impact how optical photons (but only optical photons) are
store currently.


  Commit: fd0599844297816dfe247b5744b7eecccb5eb790
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2Ffd0599844297816dfe247b5744b7eecccb5eb790&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Ced25fe6855294141dd7808d69dde3649%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636869975060902875&sdata=oP3bBQPFv3EohjSFetFx56sBmZgSTgdBtP%2F%2F9m8nywo%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2018-08-01 (Wed, 01 Aug 2018)

  Changed paths:
    M src/remollGenericDetector.cc

  Log Message:
  -----------
  No Edep field (pulled in through cherry-pick)


  Commit: 70a3e8d1abcabda887bd96618ea47f8ac8d99dba
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F70a3e8d1abcabda887bd96618ea47f8ac8d99dba&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Ced25fe6855294141dd7808d69dde3649%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636869975060902875&sdata=kAzQkBEChYoYtRGqGsSqmAcrAzHBavWJc5Z4DUPyT4A%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2018-08-01 (Wed, 01 Aug 2018)

  Changed paths:
    M src/remollGenericDetector.cc

  Log Message:
  -----------
  Merge pull request #143 from JeffersonLab/bugfix-issue-127-optical-photons

Merge bugfix issue 127: For optical photon that reach geom boundary, store post step point


  Commit: 841b10e9fed207485193d8783d04fa1bcdfe9d07
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F841b10e9fed207485193d8783d04fa1bcdfe9d07&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Ced25fe6855294141dd7808d69dde3649%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636869975060913220&sdata=NXFTBMuamZFHaNQdoBrt6d%2BpCZ7B69Is3W%2FpHqNkauI%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    R .github/ISSUE_TEMPLATE
    A .github/ISSUE_TEMPLATE/bug_report.md
    A .github/ISSUE_TEMPLATE/feature_request.md

  Log Message:
  -----------
  Updated issue templates


  Commit: 654ff8dd10b9d1431f6aa6c534d8864c84fc4556
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F654ff8dd10b9d1431f6aa6c534d8864c84fc4556&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Ced25fe6855294141dd7808d69dde3649%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636869975060913220&sdata=VMZZ4YCzi1FxvYX2%2BR6VA7Y%2Bff5LKL4WuKNXyVQ0G40%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    R .github/ISSUE_TEMPLATE
    A .github/ISSUE_TEMPLATE/bug_report.md
    A .github/ISSUE_TEMPLATE/feature_request.md
    M src/remollGenericDetector.cc

  Log Message:
  -----------
  Merge branch 'master' into develop

Bugfix #127 PR #143 was only merged into master, not into develop.
Probably explains a few things in hindsight......... This merge now
mostly ignores the bugfix into master since we ended up fixing this
independently in develop.


Compare: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcompare%2Fe7e965dc3252...654ff8dd10b9&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Ced25fe6855294141dd7808d69dde3649%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636869975060913220&sdata=pKFnVYRJHXY%2FOlhVk4W7l7LAbuypn8l6DAJGyQjNbxs%3D&reserved=0


More information about the 12gevmoller_sim mailing list