[12gevmoller_sim] [JeffersonLab/remoll] 61a81f: Bugfix to issue #172. Now kryptonite works again.

[GitHub]

  Branch: refs/heads/develop
  Home:   https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cb53b2bbc851145b0be9808d67b152620%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636831728097628692&sdata=JUzOm91Wfz4Yp89NE36WE5HW5WpjtaCVmHB18pZh%2BiM%3D&reserved=0
  Commit: 61a81f76c01e4df5f180f50fcf78eea1800fd248
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F61a81f76c01e4df5f180f50fcf78eea1800fd248&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cb53b2bbc851145b0be9808d67b152620%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636831728097628692&sdata=TzTgAsrjSwzUThFzqFvIRgRcNm1aO2RJzPkaWlbNUXE%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-01-14 (Mon, 14 Jan 2019)

  Changed paths:
    M analysis/issues/issue172.C
    M include/remollDetectorConstruction.hh
    M include/remollGenericDetector.hh
    M macros/issues/issue172.mac
    M src/remollActionInitialization.cc
    M src/remollDetectorConstruction.cc
    M src/remollGenericDetector.cc

  Log Message:
  -----------
  Bugfix to issue #172. Now kryptonite works again.

Since this is a quite major set of changes to how some of the hits
are being stored, I am putting this in a bugfix branch first so I
can test optical photon hit behavior and let @cameronc137 take a look.

In any case, here's hit behavior:
- by default only hits are stored that satisfy the following:
  - charge particle, energy > 0.1 MeV
  - anywhere along a primary track
  - first hit in volume for secondary track
- all hits (even those not stored) are added to the detector sums

To modify this behavior you can use
```
/remoll/SD/type 4001 lowenergyneutral
/remoll/SD/type 4001 secondaries
```
along with similar GDML statements (also possible: `opticalphotons`
and `boundaryhits`).

As for kryptonite, this was all moved to remollDetectorConstruction
and stepping action was removed (since now not useful). Here is the
code for kryptonite:
```
/remoll/kryptonite/verbose 1
/remoll/kryptonite/add G4_Pb
/remoll/kryptonite/list
/remoll/kryptonite/enable
/remoll/kryptonite/disable
```
(This is different from previous `/remoll/kryptonite/set true` since
we need a method and those don't work with `G4GenericMessenger::DefineMethod`
since a G4bool looks like a G4int and yada yada yada.)

Finally, kryptonite now acts by setting all volumes that have the
specified material in question with userlimits to (0,0,0,inf,inf).
This means that all energy is deposited in the first hit, making
the sums correct. Essentially it sets the userlimits to:
```
/remoll/geometry/userlimits/usermaxallowedstep krypt_logical 0.0*mm
/remoll/geometry/userlimits/usermaxtracklength krypt_logical 0.0*mm
/remoll/geometry/userlimits/usermaxtime krypt_logical 0.0*ns
/remoll/geometry/userlimits/userminekine krypt_logical 1000*GeV
/remoll/geometry/userlimits/userminrange krypt_logical 1000*km
```
for those volumes. It does mean that steplimiter must be enabled
by default. And if you disable steplimiter and still try to use
userlimits or kryptonite there is no warning... so don't do that.


  Commit: 42337ae7b1e4c23c29ab1ceecad2ffaaee7f6aee
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F42337ae7b1e4c23c29ab1ceecad2ffaaee7f6aee&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cb53b2bbc851145b0be9808d67b152620%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636831728097638030&sdata=XY6HqZ2OBMOrnQEu5xNevTcNymdW%2BesuUv98oOiHBoo%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-01-15 (Tue, 15 Jan 2019)

  Changed paths:
    M src/remollGenericDetector.cc

  Log Message:
  -----------
  Rename /remoll/SD/detect_opticalphoton to use space

/remoll/SD/detect opticalphoton detno


  Commit: 9c679b9af179c6f890aad2c6813ec22854a738f2
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2F9c679b9af179c6f890aad2c6813ec22854a738f2&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cb53b2bbc851145b0be9808d67b152620%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636831728097638030&sdata=A%2BTgJ4Atw%2F%2F%2B5JoL8SQXKvLgIJXFF5g%2BCDGU%2B8%2BtDNI%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-01-15 (Tue, 15 Jan 2019)

  Changed paths:
    M src/remollGenericDetector.cc

  Log Message:
  -----------
  lowenergyneutrals does not apply to optical photons

i.e. setting dettype to opticalphoton does not also require
lowenergyneutrals


  Commit: efa5cb94893d1ca12f800f9a971c7cd3c69b8677
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2Fefa5cb94893d1ca12f800f9a971c7cd3c69b8677&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cb53b2bbc851145b0be9808d67b152620%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636831728097638030&sdata=7RQXBsgIvm8SawK6WO0jOKf6ZEEIfTouUaYMggnNJEE%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-01-15 (Tue, 15 Jan 2019)

  Changed paths:
    M include/remollGenericDetector.hh
    M macros/issues/issue172.mac

  Log Message:
  -----------
  Use previous nomenclature, despite inconsistency...

You can use: opticalphoton, lowenergyneutral, secondaries, boundaryhits


  Commit: c24ebb3bba0686f876c18d205bd4de8e488a0a4c
      https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcommit%2Fc24ebb3bba0686f876c18d205bd4de8e488a0a4c&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cb53b2bbc851145b0be9808d67b152620%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636831728097638030&sdata=AlOYfZguTP7jZ3TuZKv%2F7kINPahjgJI2CQPjQurctao%3D&reserved=0
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-01-15 (Tue, 15 Jan 2019)

  Changed paths:
    M analysis/issues/issue172.C
    M include/remollDetectorConstruction.hh
    M include/remollGenericDetector.hh
    M macros/issues/issue172.mac
    M src/remollActionInitialization.cc
    M src/remollDetectorConstruction.cc
    M src/remollGenericDetector.cc

  Log Message:
  -----------
  Merge pull request #182 from JeffersonLab/bugfix-issue-172

Bugfix to issue #172. Now kryptonite works again.


Compare: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffersonLab%2Fremoll%2Fcompare%2F630bc8608dd0...c24ebb3bba06&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cb53b2bbc851145b0be9808d67b152620%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636831728097638030&sdata=8rBY%2FRj0YBcTGKTmsDnNfHiYmgMuUJEJ8AMyNgAw3c4%3D&reserved=0
      **NOTE:** This service has been marked for deprecation: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdeveloper.github.com%2Fchanges%2F2018-04-25-github-services-deprecation%2F&data=02%7C01%7C12gevmoller_sim%40jlab.org%7Cb53b2bbc851145b0be9808d67b152620%7Cb4d7ee1f4fb34f0690372b5b522042ab%7C1%7C1%7C636831728097638030&sdata=kEwsArAK%2BCwFF2qCUrhiSogikLg5BCIqH7wR%2Bf8XqlM%3D&reserved=0

      Functionality will be removed from GitHub.com on January 31st, 2019.