[12gevmoller_sim] [EXTERNAL] [JeffersonLab/remoll] 8f1a1a: Fix event generator to be in the target, not downs...

Wouter Deconinck noreply at github.com
Wed Oct 2 17:00:10 EDT 2019


  Branch: refs/heads/develop
  Home:   https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll&d=DwICaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=-0uahHXTLsQsllHBZNHgOynLaY6DUxqehsUJ91-BlNY&m=Z2X-H59i9-QM_36KpG3kPXeK74pv2oP0r-ovdPV9SAw&s=XLamqRRtm0mPQxqjXNUzlDTJzq8qEN1s-xKk9eh9E6U&e= 
  Commit: 8f1a1aaa102e70d5c101d76c2152b52c814e66e4
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_8f1a1aaa102e70d5c101d76c2152b52c814e66e4&d=DwICaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=-0uahHXTLsQsllHBZNHgOynLaY6DUxqehsUJ91-BlNY&m=Z2X-H59i9-QM_36KpG3kPXeK74pv2oP0r-ovdPV9SAw&s=52vGMljm_HOMTtQ7154qtfn7u2o_al8rkDHUU7GGGY0&e= 
  Author: Wouter Deconinck <wdconinc at gmail.com>
  Date:   2019-10-01 (Tue, 01 Oct 2019)

  Changed paths:
    M src/remollBeamTarget.cc

  Log Message:
  -----------
  Fix event generator to be in the target, not downstream

Due to a sign error, the events were generated around +4587 mm instead
of around -4587 mm. The call to GetFrameTranslation should have been a
call to GetTranslation, or various equivalent sign changes.

This was not a problem before since the target was centered at zero, and
so -0 is the same...


  Commit: 292cfda52ea8a4567b0cf64b8cdfd406873ec740
      https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_commit_292cfda52ea8a4567b0cf64b8cdfd406873ec740&d=DwICaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=-0uahHXTLsQsllHBZNHgOynLaY6DUxqehsUJ91-BlNY&m=Z2X-H59i9-QM_36KpG3kPXeK74pv2oP0r-ovdPV9SAw&s=_plOcqrGrGzw3LAB2CdO4hOy8wJNuamU7Q7hValMI6Q&e= 
  Author: Wouter Deconinck <wdconinc at jlab.org>
  Date:   2019-10-02 (Wed, 02 Oct 2019)

  Changed paths:
    M src/remollBeamTarget.cc

  Log Message:
  -----------
  Merge pull request #276 from JeffersonLab/bugfix-events-generated-downstream-of-pivot

Bugfix: Fix event generator to be in the target, not downstream (MAJOR)


Compare: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_remoll_compare_55716c0725c8...292cfda52ea8&d=DwICaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=-0uahHXTLsQsllHBZNHgOynLaY6DUxqehsUJ91-BlNY&m=Z2X-H59i9-QM_36KpG3kPXeK74pv2oP0r-ovdPV9SAw&s=LQyMN_0xqBq4MSzCCpAUZaksSJdtGmDwpvPmA3jdJIE&e= 



More information about the 12gevmoller_sim mailing list