[Clas12_calcom] [EXTERNAL] Re: timelines for RGB F19-S20 ready for detector experts
Christopher Dilks
dilks at jlab.org
Thu Aug 3 18:03:12 EDT 2023
Hi Andrey, Zhiwen, and Cole,
Thanks Andrey, I merged in your fix for the EC.
Zhiwen, can you run 'git pull' and rerun the EC timelines?
Thanks,
Chris
On 8/3/23 14:55, Christopher Dilks wrote:
>
> Hi Andrey,
>
> Thanks, this makes sense. Can you make a PR to fix run_rgb.groovy please?
>
> Chris
>
> On 8/3/23 14:37, Andrey wrote:
>> I have made the commit on Cole's behalf after I fixed a few features
>> in his code. That's what you see in the history.
>> run.groovy was changed with new timelines, but rgb run script was not.
>> https://github.com/JeffersonLab/clas12-timeline/commit/c94d9e2a94b22fc909903abc4d1f65493cbed7ef#diff-52d3b9a46c349594128ee523ea88a1cd640c9b8af3635c530d1f3866b34ce44d
>> We just need to fix run_rgb.groovy to reflect new timelines, and
>> possibly remove old timeline scripts too.
>> Andrey.
>>
>> On Thu, Aug 3, 2023 at 2:03 PM Christopher Dilks via Clas12_calcom
>> <clas12_calcom at jlab.org> wrote:
>>
>> Hi Cole,
>>
>> I could not find a pull request for these changes, but I did find
>> a direct commit on `main` which includes (at least some of) them:
>> c94d9e2.
>>
>> It's not so clear what happened, but I see a difference between
>> `main` at that commit and your fork, which may indicate that not
>> all of your changes were included.
>>
>> Can you make a pull request, and make sure the box "allow edits
>> by maintainers" is checked (so I can help resolve any conflicts)?
>> Let's take further discussion off-list until we get this
>> resolved; let me know if you need any help doing this.
>>
>> Cheers,
>>
>> Chris
>>
>> On 8/3/23 12:59, L Smith wrote:
>>> Zhiwen,
>>>
>>> The v29.22_new link still shows the old EC menu and timelines
>>> (before June 8). The latest should show the new menu for EC
>>> (below). For example the latest RGK, RGA-F18 and RGC timelines
>>> show the new menu and timelines.
>>>
>>> Cole
>>>
>>> BEFORE JUNE 8
>>>
>>>
>>>
>>> AFTER JUNE 8
>>>
>>>
>>>
>>>> On Aug 3, 2023, at 12:27 PM, Zhiwen Zhao <zwzhao at jlab.org> wrote:
>>>>
>>>> All
>>>>
>>>> I updated the timeline v29.22_new here with latest
>>>> clas12-timeline main
>>>> https://clas12mon.jlab.org/rgb/pass0/v29.22_new/tlsummary/
>>>>
>>>> Note it's only for RGB F19 only, not S20 which is under work.
>>>>
>>>> Zhiwen
>>>>
>>>> On 8/2/2023 12:47 PM, Christopher Dilks wrote:
>>>>> Hi Zhiwen,
>>>>> Go ahead and try the main branch. If it fails, I'll fix it.
>>>>> In the future, we may consider running off tagged releases
>>>>> (which should be stable) instead of just the latest version on
>>>>> main (which may sometimes be unstable, until we have proper
>>>>> testing).
>>>>> Thanks,
>>>>> Chris
>>>>> On 8/2/23 12:36, Zhiwen Zhao wrote:
>>>>>> Chris
>>>>>>
>>>>>> I always used latest main branch of clas12-timeline repo and
>>>>>> never used any tag version.
>>>>>> I suppose other chefs do the same.
>>>>>>
>>>>>> Should I reproduce timeline with the latest main branch now
>>>>>> or I should wait for your suggestion?
>>>>>>
>>>>>> Zhiwen
>>>>>>
>>>>>> On 8/2/2023 11:31 AM, Christopher Dilks wrote:
>>>>>>> Dear Marco and Silvia,
>>>>>>>
>>>>>>> Marco's changes were merged in on Monday. I haven't tagged a
>>>>>>> new release yet since we have also merged in a few other
>>>>>>> general cleanup changes and improvements, but I haven't had
>>>>>>> a chance to fully test everything yet (currently automating
>>>>>>> testing, actually).
>>>>>>>
>>>>>>> Let me know if there are any issues, and if so, I'll tag a
>>>>>>> stable version with only Marco's change.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Chris
>>>>>>>
>>>>>>> On 8/2/23 11:19, Marco Mirazita via Clas12_calcom wrote:
>>>>>>>> Dear Silvia,
>>>>>>>> these timelines does not have the fix on the RICH
>>>>>>>> monitoring histograms that I committed on github just
>>>>>>>> yesterday.
>>>>>>>> Is it possible to rerun with the latest version of the
>>>>>>>> software?
>>>>>>>> Thank you,
>>>>>>>> Marco
>>>>>>>>
>>>>>>>>
>>>>>>>> Il 2023-08-02 17:11 silvia--- via Clas12_calcom ha scritto:
>>>>>>>>> Dear all,
>>>>>>>>> after completing FTOF and RF calibration, RGB F19-S20 is
>>>>>>>>> ready for the
>>>>>>>>> calibration of the other subsystems. Please check the
>>>>>>>>> timelines at
>>>>>>>>> https://clas12mon.jlab.org/rgb/pass0/v29.22/tlsummary/ ,
>>>>>>>>> and let me and
>>>>>>>>> Zhiwen know which runs you need to have cooked for your
>>>>>>>>> subsystem.
>>>>>>>>> Ideally, it would be great if you provided, when possible,
>>>>>>>>> a run range, so
>>>>>>>>> we can optimize the cooking for everyone.
>>>>>>>>> Thanks a lot for your support!
>>>>>>>>> Best regards,
>>>>>>>>> Silvia
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> Clas12_calcom mailing list
>>>>>>>>> Clas12_calcom at jlab.org
>>>>>>>>> https://mailman.jlab.org/mailman/listinfo/clas12_calcom
>>>>>>>> _______________________________________________
>>>>>>>> Clas12_calcom mailing list
>>>>>>>> Clas12_calcom at jlab.org
>>>>>>>> https://mailman.jlab.org/mailman/listinfo/clas12_calcom
>>>
>> _______________________________________________
>> Clas12_calcom mailing list
>> Clas12_calcom at jlab.org
>> https://mailman.jlab.org/mailman/listinfo/clas12_calcom
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.jlab.org/pipermail/clas12_calcom/attachments/20230803/b0815fe8/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2023-08-03 at 12.49.22 PM.png
Type: image/png
Size: 55356 bytes
Desc: not available
URL: <https://mailman.jlab.org/pipermail/clas12_calcom/attachments/20230803/b0815fe8/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2023-08-03 at 12.49.59 PM.png
Type: image/png
Size: 85659 bytes
Desc: not available
URL: <https://mailman.jlab.org/pipermail/clas12_calcom/attachments/20230803/b0815fe8/attachment-0003.png>
More information about the Clas12_calcom
mailing list