<meta http-equiv="Content-Type" content="text/html; charset=utf-8"><div dir="ltr"><div>I have made the commit on Cole's behalf after I fixed a few features in his code. That's what you see in the history.</div><div>run.groovy was changed with new timelines, but rgb run script was not.</div><div><a href="https://github.com/JeffersonLab/clas12-timeline/commit/c94d9e2a94b22fc909903abc4d1f65493cbed7ef#diff-52d3b9a46c349594128ee523ea88a1cd640c9b8af3635c530d1f3866b34ce44d">https://github.com/JeffersonLab/clas12-timeline/commit/c94d9e2a94b22fc909903abc4d1f65493cbed7ef#diff-52d3b9a46c349594128ee523ea88a1cd640c9b8af3635c530d1f3866b34ce44d</a><br></div><div>We just need to fix run_rgb.groovy to reflect new timelines, and possibly remove old timeline scripts too.</div><div>Andrey.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 3, 2023 at 2:03 PM Christopher Dilks via Clas12_calcom <<a href="mailto:clas12_calcom@jlab.org">clas12_calcom@jlab.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>
<div>
<p>Hi Cole, <br>
</p>
<p>I could not find a pull request for these changes, but I did find
a direct commit on `main` which includes (at least some of) them:
<span><span>c94d9e2</span></span>. </p>
<p>It's not so clear what happened, but I see a difference between
`main` at that commit and your fork, which may indicate that not
all of your changes were included.</p>
<p>Can you make a pull request, and make sure the box "allow edits
by maintainers" is checked (so I can help resolve any conflicts)?
Let's take further discussion off-list until we get this resolved;
let me know if you need any help doing this.</p>
<p>Cheers,</p>
<p>Chris<br>
</p>
<div>On 8/3/23 12:59, L Smith wrote:<br>
</div>
<blockquote type="cite">
<div style="overflow-wrap: break-word;">Zhiwen,
<div><br>
</div>
<div>The v29.22_new link still shows the old EC menu
and timelines (before June 8). The latest should show the
new menu for EC (below). For example the latest RGK, RGA-F18
and RGC timelines show the new menu and timelines. </div>
<div><br>
</div>
<div>Cole </div>
<div><br>
</div>
<div>BEFORE JUNE 8</div>
<div><br>
<div><img id="m_-4998612618274113011A08DAE54-03EB-4604-816A-9789CD9953E4" src="cid:189bcaecbb715b7c3031" width="226" height="231"></div>
<div><br>
</div>
<div><br>
</div>
<div>AFTER JUNE 8</div>
<div><br>
</div>
<div><img id="m_-49986126182741130116501C874-F6C5-4364-BBDE-CD40D13C9ADE" src="cid:189bcaecbb7a9ad4a1f2" width="321" height="306"></div>
<div><br>
<div><br>
<blockquote type="cite">
<div>On Aug 3, 2023, at 12:27 PM, Zhiwen Zhao
<<a href="mailto:zwzhao@jlab.org" target="_blank">zwzhao@jlab.org</a>>
wrote:</div>
<br>
<div>
<div>All<br>
<br>
I updated the timeline v29.22_new here with latest
clas12-timeline main<br>
<a href="https://clas12mon.jlab.org/rgb/pass0/v29.22_new/tlsummary/" target="_blank">https://clas12mon.jlab.org/rgb/pass0/v29.22_new/tlsummary/</a><br>
<br>
Note it's only for RGB F19 only, not S20 which is
under work.<br>
<br>
Zhiwen<br>
<br>
On 8/2/2023 12:47 PM, Christopher Dilks wrote:<br>
<blockquote type="cite">Hi Zhiwen,<br>
Go ahead and try the main branch. If it fails,
I'll fix it.<br>
In the future, we may consider running off tagged
releases (which should be stable) instead of just
the latest version on main (which may sometimes be
unstable, until we have proper testing).<br>
Thanks,<br>
Chris<br>
On 8/2/23 12:36, Zhiwen Zhao wrote:<br>
<blockquote type="cite">Chris<br>
<br>
I always used latest main branch of
clas12-timeline repo and never used any tag
version.<br>
I suppose other chefs do the same.<br>
<br>
Should I reproduce timeline with the latest main
branch now or I should wait for your suggestion?<br>
<br>
Zhiwen<br>
<br>
On 8/2/2023 11:31 AM, Christopher Dilks wrote:<br>
<blockquote type="cite">Dear Marco and
Silvia,<br>
<br>
Marco's changes were merged in on Monday. I
haven't tagged a new release yet since we have
also merged in a few other general cleanup
changes and improvements, but I haven't had a
chance to fully test everything yet (currently
automating testing, actually).<br>
<br>
Let me know if there are any issues, and if
so, I'll tag a stable version with only
Marco's change.<br>
<br>
Thanks,<br>
<br>
Chris<br>
<br>
On 8/2/23 11:19, Marco Mirazita via
Clas12_calcom wrote:<br>
<blockquote type="cite">Dear Silvia,<br>
these timelines does not have the fix on the
RICH monitoring histograms that I committed
on github just yesterday.<br>
Is it possible to rerun with the latest
version of the software?<br>
Thank you,<br>
Marco<br>
<br>
<br>
Il 2023-08-02 17:11 silvia--- via
Clas12_calcom ha scritto:<br>
<blockquote type="cite">Dear all,<br>
after completing FTOF and RF calibration,
RGB F19-S20 is ready for the<br>
calibration of the other subsystems.
Please check the timelines at<br>
<a href="https://clas12mon.jlab.org/rgb/pass0/v29.22/tlsummary/" target="_blank">https://clas12mon.jlab.org/rgb/pass0/v29.22/tlsummary/</a>
, and let me and<br>
Zhiwen know which runs you need to have
cooked for your subsystem.<br>
Ideally, it would be great if you
provided, when possible, a run range, so<br>
we can optimize the cooking for everyone.<br>
Thanks a lot for your support!<br>
Best regards,<br>
Silvia<br>
<br>
<br>
_______________________________________________<br>
Clas12_calcom mailing list<br>
<a href="mailto:Clas12_calcom@jlab.org" target="_blank">Clas12_calcom@jlab.org</a><br>
<a href="https://mailman.jlab.org/mailman/listinfo/clas12_calcom" target="_blank">https://mailman.jlab.org/mailman/listinfo/clas12_calcom</a><br>
</blockquote>
_______________________________________________<br>
Clas12_calcom mailing list<br>
<a href="mailto:Clas12_calcom@jlab.org" target="_blank">Clas12_calcom@jlab.org</a><br>
<a href="https://mailman.jlab.org/mailman/listinfo/clas12_calcom" target="_blank">https://mailman.jlab.org/mailman/listinfo/clas12_calcom</a><br>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
_______________________________________________<br>
Clas12_calcom mailing list<br>
<a href="mailto:Clas12_calcom@jlab.org" target="_blank">Clas12_calcom@jlab.org</a><br>
<a href="https://mailman.jlab.org/mailman/listinfo/clas12_calcom" rel="noreferrer" target="_blank">https://mailman.jlab.org/mailman/listinfo/clas12_calcom</a><br>
</blockquote></div>