<div dir="ltr">Hi Paul,<div>I hope it not too much to ask that you make a branch in the repository and check in your changes there. I would then be willing to merge these changes into the trunk after I run my own tests with a1c.</div>
</div><div class="gmail_extra"><br clear="all"><div>-- <a href="https://sites.google.com/site/theodoregoetz/" target="_blank">Johann</a></div>
<br><br><div class="gmail_quote">On Tue, Apr 29, 2014 at 11:47 AM, Paul Mattione <span dir="ltr"><<a href="mailto:pmatt@jlab.org" target="_blank">pmatt@jlab.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Is anyone planning on fixing this?<br>
<span class="HOEnZb"><font color="#888888"><br>
- Paul<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Apr 11, 2014, at 3:51 PM, Paul Mattione wrote:<br>
<br>
> I've found a bug in the C++ version of the new start counter reconstruction code for CLAS-6. It only effects reconstruction of Monte Carlo data: ST hits are being reconstructed using the calibration constants from the run number in the HEAD bank rather than run number 1 (resulting in hit times that were off by ~700 ns).<br>
><br>
> I modified my personal reconstruction code to use separate run #'s for the ST geometry and calibration constants, but reconstruction crashes because no calibration constants have ever been defined for runs 1-10 for some of the constants that are only needed by the C++ reconstruction code (e.g. STN_CALIB / adc2edep / reg1limit, needed by SThit::GetEnergyDeposit() in st/stpp_SThit.cc).<br>
><br>
> Could someone with advanced knowledge of the start counter simulation and reconstruction codes set the missing calibration constants for runs 1-10?<br>
><br>
> Until this is fixed, I recommend running your Monte Carlo simulations using the Fortran reconstruction code ("set st_type 1;" in your tcl file).<br>
><br>
> - Paul<br>
><br>
> FOR DEVELOPERS:<br>
><br>
> My code modifications to use separate run #'s for the ST geometry and calibration constants can be found on ifarm1102 at (note that this is g13-era svn/scons software, so a straight copy may break your build):<br>
><br>
> Code: /w/hallb/clasg13/pmatt/svnroot_clas6/g13a_pass2v2_64bit/trunk/<br>
> Environment Variables: /home/pmatt/env_jlab_clas6_mccook_centos62<br>
><br>
> In this trunk, I made small modifications to the following files:<br>
><br>
> detector/st/stpp_JCalibration.*<br>
> detector/st/st_brun.F<br>
> detector/st/stpp_initialize.cc<br>
> detector/st/stpp_STposition.*<br>
> calibration/tag_calib/tagraw.cxx<br>
><br>
> If you want to test using your own source code, I recommend diff'ing these files with your current source code and only copying the changes that look related to this issue. Thank you for helping with this.<br>
><br>
><br>
> _______________________________________________<br>
> Clas_offline mailing list<br>
> <a href="mailto:Clas_offline@jlab.org">Clas_offline@jlab.org</a><br>
> <a href="https://mailman.jlab.org/mailman/listinfo/clas_offline" target="_blank">https://mailman.jlab.org/mailman/listinfo/clas_offline</a><br>
<br>
<br>
_______________________________________________<br>
Clas_offline mailing list<br>
<a href="mailto:Clas_offline@jlab.org">Clas_offline@jlab.org</a><br>
<a href="https://mailman.jlab.org/mailman/listinfo/clas_offline" target="_blank">https://mailman.jlab.org/mailman/listinfo/clas_offline</a><br>
</div></div></blockquote></div><br></div>