<html><body><div style="font-family: arial, helvetica, sans-serif; font-size: 12pt; color: #000000"><div><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">Mike,</span><br><br><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">My answers are inline in blue.</span><br><br>It appears that your expectation is not correct.<br><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">I do not understand what you mean by expectation.</span><br><br>I stopped reviewing the code when I found the following.<br><br>Rung 0<br>The MPS_WA_Value will always be greater than ADC_Readback_MPS<br><br>The WA value is the PSU set value 0 to 100% or 0 to 999999<br>The readback value is always a factor of 10 less.</div><div><br><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">We checked the MPS_Commands portion of the PLC code and were unable to find the units for the MPS_WA_Value. We did not know the units for the current tags (I_True, I_Coarse, and ADC_Readback_MPS) and believed the tags were in the units of Amps.</span><br><br><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">We had checked the newly developed PLC code (which uses Amps for the tags) with the Python code (developed by DSG) which simulates Danfysik power supply; the program executed correctly. We believe that the error in the original PLC program is due to the difference in units. We guess that the ADC_Readback is in ppm based on the conversion numbers used in the PLC program and on our knowledge of how other Danfysik power supplies work.</span><br><br>Rung 2<br>I_MOL is the current set value 0 to 3000 amps., it will never match the ADC readback.<br></div><div><br data-mce-bogus="1"></div><div><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">As mentioned above we were unclear about the units used. We are guessing ADC readback is in ppm, which is why, we think, you said I_MOL [Amps] will never match ADC readback [ppm] (Because different units are being used).</span><br><br>Unknown, possible runaway, condition when there is an interlock, the PSU ramps down, operator resets the interlock, and restarts.<br><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">What do you mean by "unknown, possible runaway, condition when there is an interlock, the PSU ramps down, operator resets the interlock, and restarts"?</span><br><br>Cheers,<br>Mike<br><br><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">The current loop regulation is not a separate routine, but a modification to the existing routine which takes place in both the MPS_Commands ladder logic routine and the Q1/Q2/Q3 function block diagram; therefore, it is not possible to send you only what I added/modified.</span><br><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">I can add these changes to a copy of the latest program and specify where the changes are located.</span><br></div><div><br data-mce-bogus="1"></div><div><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">Regards,</span><br><span style="color: rgb(0, 0, 255);" data-mce-style="color: #0000ff;">Amanda</span><br><br><br><br><br>----- Original Message -----<br>From: "Mike Fowler" <fowler@jlab.org><br>To: "Amanda Hoebel" <amandah@jlab.org><br>Cc: "dsg-hallc controls" <dsg-hallc_controls@jlab.org><br>Sent: Wednesday, August 1, 2018 10:29:53 AM<br>Subject: Re: [Dsg-hallc_controls] Current regulation loop<br><br>Hi,<br><br>We need a copy of your code and only the changes you propose to make.<br>The ADC file you modified is old and if loaded into the PLC it would cause operational problems.<br>We need to be able to copy and paste your code into the running system, not replace the running system.<br><br>Cheers,<br>Mike<br><br><br><br><br>----- Original Message -----<br>From: "Mike Fowler" <fowler@jlab.org><br>To: "Amanda Hoebel" <amandah@jlab.org><br>Cc: "dsg-hallc controls" <dsg-hallc_controls@jlab.org><br>Sent: Wednesday, August 1, 2018 9:02:16 AM<br>Subject: Re: [Dsg-hallc_controls] Current regulation loop<br><br>Hi,<br><br>It appears that your expectation is not correct.<br>I stopped reviewing the code when I found the following.<br><br>Issues found:<br><br>Rung 0<br>The MPS_WA_Value will always be greater than ADC_Readback_MPS<br><br>The WA value is the PSU set value 0 to 100% or 0 to 999999<br>The readback value is always a factor of 10 less.<br><br>Rung 2<br>I_MOL is the current set value 0 to 3000 amps., it will never match the ADC readback.<br><br>Unknown, possible runaway, condition when there is an interlock, the PSU ramps down, operator resets the interlock, and restarts.<br><br>Cheers,<br>Mike<br><br><br><br><br>----- Original Message -----<br>From: "Amanda Hoebel" <amandah@jlab.org><br>To: "dsg-hallc controls" <dsg-hallc_controls@jlab.org><br>Sent: Monday, July 30, 2018 4:49:35 PM<br>Subject: [Dsg-hallc_controls] Current regulation loop<br><br>Hello Steve and Mike,<br><br>Updated versions of the HMS and SHMS programs to include the current regulation loop are in the M: drive, "M:\dsg-hallc_controls\HMS_Controls_V20_current_loop.ACD" and "M:\dsg-hallc_controls\SHMS_V_20_current_loop.ACD". The program was tested using the DSG test PLC and a serial program to simulate the danfysik power supply. The program ran as expected and allowed the user to change setpoints mid-ramp without issue. <br><br>Regards,<br>Amanda<br>_______________________________________________<br>Dsg-hallc_controls mailing list<br>Dsg-hallc_controls@jlab.org<br>https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls<br>_______________________________________________<br>Dsg-hallc_controls mailing list<br>Dsg-hallc_controls@jlab.org<br>https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls<br></div></div></body></html>