<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">I found a few more things, sorry.<br>
<br>
There are three operational modes:<br>
a. Manual, current set point equals HMI_Set_Current_Value.<br>
b. Calculated, I_Q1 is calculated from the momentum input.<br>
c. MOL regulation with I_Target & I_MOL from EPICS.<br>
<br>
Code comments:<br>
1. If an Interlock occurs the regulation is not stopped. Need
this.<br>
2. If the MPS is ramping and the operator stops the regulation,
the I_coarse value should be sent to the MPS. (Stop where it is)<br>
3. There is no check to make sure the MOL value is within the
operational limits.<br>
4. If the analog signal I_coarse is less than the Last_I_Sent by
even a small fraction the MOL value is used.<br>
5. If I_coarse by chance happens to be equal to Last_I_Sent
nothing happens.<br>
6. Only Q1_I_Target has an associated MOL value, not I_Q1 or
HMI_Set_Current_Value.<br>
7. Consider this:<br>
If I_coarse is equal to Last_I_Sent +/- a few amps<br>
true, MPS is at setpoint<br>
false, The MPS is still ramping, something happened, or the
MPS tripped and the Last_I_Sent was not updated. (Interlock?)<br>
or the window is too small. Determine what to do.<br>
<br>
8. Compare Q1_I_Target to Last_I_Sent to determine ramp direction
instead of the analog I_coarse.<br>
<br>
Cheers,<br>
Mike<br>
<br>
<br>
<br>
<br>
On 9/25/2018 10:37 AM, Mike Fowler wrote:<br>
</div>
<blockquote type="cite"
cite="mid:04b835d5-5054-03e3-91a4-3b537dd05e97@jlab.org">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div class="moz-cite-prefix">Hi,<br>
<br>
Comments.<br>
<br>
The ability to manually input a current and send it without a
MOL value has been removed. <br>
Must be included.<br>
<br>
Cheers,<br>
Mike<br>
<br>
<br>
<br>
On 9/20/2018 9:12 AM, Amanda Hoebel wrote:<br>
</div>
<blockquote type="cite"
cite="mid:59817053.2238488.1537449142333.JavaMail.zimbra@jlab.org">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<div style="font-family: arial, helvetica, sans-serif;
font-size: 12pt; color: #000000">
<div>Hi Mike,<br data-mce-bogus="1">
</div>
<div><br data-mce-bogus="1">
</div>
<div>I have attached pdfs of the field regulation routine for
HMS Q1. If this is correct I will make the routines for HMS
Q2 and Q3, and for the quads in SHMS.<br data-mce-bogus="1">
</div>
<div><br data-mce-bogus="1">
</div>
<div>Regards,<br data-mce-bogus="1">
</div>
<div>Amanda<br data-mce-bogus="1">
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Dsg-hallc_controls mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Dsg-hallc_controls@jlab.org" moz-do-not-send="true">Dsg-hallc_controls@jlab.org</a>
<a class="moz-txt-link-freetext" href="https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls" moz-do-not-send="true">https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls</a>
</pre>
</blockquote>
<p><br>
</p>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Dsg-hallc_controls mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Dsg-hallc_controls@jlab.org">Dsg-hallc_controls@jlab.org</a>
<a class="moz-txt-link-freetext" href="https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls">https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls</a>
</pre>
</blockquote>
<p><br>
</p>
</body>
</html>