[Halld-cal] Fwd: r9772 - in trunk/sim-recon/src: libraries/BCAL programs/Simulation/HDGeant programs/Simulation/mcsmear

[David Lawrence]

Hi All,

   I have just committed changes reverting the default for the BCAL 
simulation back to the original
scheme. See the commit log below for details. This is in response to a 
request from Paul who pointed
that since the reconstruction is not able to handle the new scheme yet, 
the changes made are quite
disruptive to those using the reconstruction for analysis tasks. As 
noted in the log, some annoying
warning messages will be appearing at startup of the mcsmear and any 
DANA program to remind
us that this issue is still unresolved.

   This reversion is not a simple backing out of previous changes as the 
mcsmear switch was moved
from a compile time to a run time option. In other words, new code was 
generated and with it, the
possibility of new bugs. I think the likelihood of a problem is small 
but if any new issues do develop,
please let me know.

Regards,
-David

-------- Original Message --------
Subject: 	r9772 - in trunk/sim-recon/src: libraries/BCAL 
programs/Simulation/HDGeant programs/Simulation/mcsmear
Date: 	Wed, 10 Oct 2012 20:12:28 -0400
From: 	Hall-D.SVN.Repository at jlab.org
To: 	richard.t.jones at uconn.edu, davidl at jlab.org



Author: davidl
Date: 2012-10-10 20:12:27 -0400 (Wed, 10 Oct 2012)
New Revision: 9772

Added:
    trunk/sim-recon/src/programs/Simulation/mcsmear/smear_bcal_deprecated.cc
Modified:
    trunk/sim-recon/src/libraries/BCAL/DBCALPoint.cc
    trunk/sim-recon/src/libraries/BCAL/DBCALPoint_factory.cc
    trunk/sim-recon/src/libraries/BCAL/DBCALPoint_factory.h
    trunk/sim-recon/src/programs/Simulation/HDGeant/hitBCal.cc
    trunk/sim-recon/src/programs/Simulation/mcsmear/mcsmear.cc
    trunk/sim-recon/src/programs/Simulation/mcsmear/smear_bcal.cc
Log:
Reverting BCAL simulation back to original version as the default.
This is in response to Paul's request since the reconstruction is
not yet ready to handle the new scheme.

The change is not a complete reversal though:

1. Both types of BCAL data are now written out by default from the
BCAL in hdgeant.

2. Which method is used (new or old) in mcsmear is chosen by
command line parameter (-D) with the default being the old.

3. The DBCALPoint object no longer scales the signal amplitude
to convert from ADC counts to rough GeV since that is not
needed by the old scheme. This must be changed in the code
and recompiled to get the "new" behavior.

4. Both mcsmear and all DANA programs will print an annoying
warning message to remind users that they are using a deprecated
method.






-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://mailman.jlab.org/pipermail/halld-cal/attachments/20121010/918a511b/attachment.html