[Halld-cal] Correct values for NSA/NSB

[Michael Staib]

Ok, Mark wants me to talk about it at the offline meeting today so we can decide. 

Will has noticed that it appears the BOR config is missing for a few of files we took with the old settings. We have only seen this in one run (10591), but are just starting to check others. The files where this is missing will fall back on 26 samples. It becomes a question of if you’d prefer the correct result when available, or a consistent result across all runs with the incorrect values. Since you changed the values in the config files, this won’t be a problem in the future.
 
--
Michael Staib
Graduate Student, Dept. of Physics
Carnegie Mellon University
mstaib at cmu.edu
phone: 412-268-2983



> On Mar 30, 2016, at 8:48 AM, Mark Macrae Dalton <dalton at jlab.org> wrote:
> 
> Hi Mike,
> 
> I think that you should just push to the master branch.  It’s a relatively small change and it’s not going to break anything.  I think we should bit the bullet and get this started so that all the downstream calibrations etc. can be done done.
> 
> Best,
> Mark Macrae Dalton
> 
> 
> 
>> On Mar 29, 2016, at 1:55 PM, Michael Staib <mstaib at andrew.cmu.edu <mailto:mstaib at andrew.cmu.edu>> wrote:
>> 
>> Hi All,
>> 
>> I have pushed a branch to Github, called f250_NSA_NSB, that grabs the correct values for NSA and NSB from the flash registers when the BOR record is available. My thoughts are to leave the code on a branch for now until calibration constants are ready for the fixed values. 
>> 
>> In case you are unaware from previous meetings, it was found that NSB = 0 is an invalid setting on the current version of the f250. For the BCAL, the configuration file had NSB = 0 and NSA=26, FCAL, NSB = 0 and NSA=15, so we were subtracting off 26 and 15 samples of pedestal, respectively. In reality, on the flash NSB was being forced to 1. The new code will correctly subtract 27 and 16 samples from the BCAL/FCAL by grabbing these values from the registers. This will obviously cause some small shift in the energy calibrations.
>> 
>> If you think I should just pull the fix into the master branch, let me know.
>> 
>> --
>> Michael Staib
>> Graduate Student, Dept. of Physics
>> Carnegie Mellon University
>> mstaib at cmu.edu <mailto:mstaib at cmu.edu>
>> phone: 412-268-2983
>> 
>> 
>> 
>> 
>> _______________________________________________
>> Halld-cal mailing list
>> Halld-cal at jlab.org
>> https://mailman.jlab.org/mailman/listinfo/halld-cal
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.jlab.org/pipermail/halld-cal/attachments/20160330/c7e83249/attachment-0001.html>