[Halld-offline] compiler warnings

[Beni Zihlmann]

Hi All,
using gcc 4.4.5 on a 64 bit machine I give you here the list of all 
warnings I get
for our code in the sim-recon tree:

DBCALShower_factory.cc: In member function ‘void 
DBCALShower_factory::CeleToArray()’:
DBCALShower_factory.cc:410: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:410: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:410: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc: In member function ‘void 
DBCALShower_factory::PreCluster(jana::JEventLoop*)’:
DBCALShower_factory.cc:498: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:498: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:510: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:518: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:518: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:525: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:525: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:535: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:542: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:552: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:559: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:571: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:572: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc: In member function ‘void 
DBCALShower_factory::ClusAnalysis()’:
DBCALShower_factory.cc:788: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:800: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc:804: warning: suggest parentheses around 
comparison in operand of ‘&’
DBCALShower_factory.cc: In member function ‘void 
DBCALShower_factory::Clus_Break(int)’:
DBCALShower_factory.cc:945: warning: suggest parentheses around 
comparison in operand of ‘&’

DLorentzDeflections.cc: In function ‘void locate(const double*, int, 
double, int*)’:
DLorentzDeflections.cc:15: warning: suggest parentheses around 
comparison in operand of ‘==’

DMaterialMap.cc: In member function ‘double 
DMaterialMap::EstimatedDistanceToBoundary(const DVector3&, const 
DVector3&)’:
DMaterialMap.cc:317: warning: suggest explicit braces to avoid ambiguous 
‘else’
DMaterialMap.cc:328: warning: suggest explicit braces to avoid ambiguous 
‘else’
ar rv .lib/Linux-x86_64/libHDGEOMETRY.a DMaterialMap.o

hddm_s.c: In function ‘open_s_HDDM’:
hddm_s.c:7628: warning: ignoring return value of ‘fgets’, declared with 
attribute warn_unused_result

root2email.cc:23: warning: deprecated conversion from string constant to 
‘char*’
root2email.cc: In function ‘int main(int, char**)’:
root2email.cc:78: warning: ignoring return value of ‘int system(const 
char*)’, declared with attribute warn_unused_result
root2email.cc: In function ‘void AddPlot(TFile&, std::string)’:
root2email.cc:113: warning: ignoring return value of ‘int system(const 
char*)’, declared with attribute warn_unused_result
root2email.cc:123: warning: ignoring return value of ‘int system(const 
char*)’, declared with attribute warn_unused_result
root2email.cc:129: warning: ignoring return value of ‘int system(const 
char*)’, declared with attribute warn_unused_result

hddm_merge_events.cc: In function ‘void ParseCommandLineArguments(int, 
char**)’:
hddm_merge_events.cc:208: warning: deprecated conversion from string 
constant to ‘char*’

hddm_merge_files.cc: In function ‘void ParseCommandLineArguments(int, 
char**)’:
hddm_merge_files.cc:117: warning: deprecated conversion from string 
constant to ‘char*’

genr8.c: In function ‘main’:
genr8.c:264: warning: ignoring return value of ‘fgets’, declared with 
attribute warn_unused_result
genr8.c:283: warning: ignoring return value of ‘fgets’, declared with 
attribute warn_unused_result
genr8.c:302: warning: ignoring return value of ‘fgets’, declared with 
attribute warn_unused_result
genr8.c:314: warning: ignoring return value of ‘fgets’, declared with 
attribute warn_unused_result
genr8.c:335: warning: ignoring return value of ‘fgets’, declared with 
attribute warn_unused_result
genr8.c:415: warning: ignoring return value of ‘fgets’, declared with 
attribute warn_unused_result

genr8_2_hddm.cc:11: warning: deprecated conversion from string constant 
to ‘char*’

cdcdump.c: In function ‘process_event’:
cdcdump.c:58: warning: format ‘%f’ expects type ‘double’, but argument 2 
has type ‘int32_t’

hdgeant.cc: In function ‘int main(int, char**)’:
hdgeant.cc:33: warning: ignoring return value of ‘int system(const 
char*)’, declared with attribute warn_unused_result
hdgeant.cc:40: warning: ignoring return value of ‘int system(const 
char*)’, declared with attribute warn_unused_result