[Halld-offline] BCAL rotated in phi

[David Lawrence]

Hi All,

  I have just committed some changes to the repository to fix an error in the overall BCAL phi rotation. Mark Dalton noticed this in the BCAL/CDC cosmic tracks in the event viewer. (Zisis noticed it too, but didn’t walk down to my office to tell me ;))  We verified that the simulation and reconstruction were both rotated by 3.75 degrees from the physical orientation. Specifically, the entire BCAL was rotated 3.75 degrees clockwise when viewing the BCAL from downstream. The correct orientation has module 1  centered on phi =0 (i.e. beam left). 

 The update was committed to the HDDS trunk, with additional updates to the HDGEOMETRY library, BCAL library, and to hdview2 itself. All will be needed to get the full fix. 

 Please note that this does change the orientation relative to any simulation done in the past. The Data Challenge data should be self-consistent if using the REST files where reconstruction was already applied. (Paul M. can confirm this.) If you try analyzing old simulated data files with new reconstruction code though, there will likely be issues.

 I checked that things look OK in the event viewer, but have not done anything to check that the BCAL library changes are OK. Someone will need to generate new simulated data with the new HDDS and then try reconstructing it with new sim-recon to verify nothing was broken here.

Let me know if you have any questions.

Regards,
-David