[Halld-offline] danarest Crashes / Freezes Running Multithreaded

[David Lawrence]

Hi Paul,

  I’ve implemented the fix and tested it using the same setup that expressed the problem
before. It seems to work OK now. I started it up at least 5 times without a crash whereas
I got a crash every time before the fix.

  To get the fix, you need to:

1. checkout or update to the latest version of the CCDB trunk (revision 2096 or greater)

2. Rebuild CCDB (make sure you set CCDB_HOME to point to it)

3. Rebuild JANA against the new CCDB

4. Rebuild sim-recon against the newly rebuilt JANA (make sure to source the setenv.csh
    script after so your environment is up to date)

Regards,
-David

On Sep 9, 2014, at 1:44 PM, David Lawrence <davidl at jlab.org> wrote:

> 
> Hi Paul,
> 
>  I found the cause of the problem. There is a call to GetListOfNamepaths() made from one thread while 
> another is calling GetCalib(). The latter has a mutex lock around calls to the DataProvider methods while
> the former does not. Using the SQLite DB, this leads to a conflict when both try using the same mStatement
> member of the SQLiteDataProvider object. (It may well for the MySQL provider too.)
> 
>  The fix requires placing calls to mReadMutex->Lock() and mReadMutex->Release() in the 
> Calibration::GetListOfNamepaths() method in CCDB. I’ll go ahead and implement the fix and test it.
> Mark or Dmitry should probably go ahead and tag a new version once it is done and they’ve checked
> out the fix. I’ll send another e-mail once the CCDB trunk is fixed though in case you are eager.
> 
> Regards,
> -David
> 
> 
> On Sep 8, 2014, at 8:08 PM, Paul Mattione <pmatt at jlab.org> wrote:
> 
>> Has anyone else noticed crashes & freezes when running the danarest plugin multithreaded on the trunk?  It doesn't always crash or freeze, but when it does it dies early.  Because it's multithreaded it's hard to tell what's causing the problems, but several times now I've seen crashes while threads have been inside:
>> 
>> ccdb::Calibration::GetAssignment
>> ccdb::SQLiteDataProvider::LoadColumns
>> ccdb::SQLiteDataProvider::ReadIndex
>> 
>> etc.  Can someone please look into this?  Thanks.  
>> 
>> - Paul
>> 
>> 
>> _______________________________________________
>> Halld-offline mailing list
>> Halld-offline at jlab.org
>> https://mailman.jlab.org/mailman/listinfo/halld-offline
> 
> 
> _______________________________________________
> Halld-offline mailing list
> Halld-offline at jlab.org
> https://mailman.jlab.org/mailman/listinfo/halld-offline