[Halld-offline] NSAT, MAXPED, ...

[David Lawrence]

Hi All,

  I have been looking at adding NSAT and MaxPed to the BOR in answer to a
request by Sean. It turns out NSAT will already be there, buried in the adc_config[0]
word. MaxPed would normally be part of the config7 word, but at the moment I’m
masking  that off and only recording the nped part. Also, Sascha reminded me that
the values of nab now includes a 4th bit which should be interpreted as a sign bit.

 What I am going to do is replace what is now called “nped” in the actual record
with the entire config7 word and rename it to config7. I am then going to add
separate members NSAT, NSA, NSB, and MaxPed to the DBOR250Config
class. These will be filled at the time the BOR event is read in using the values
from the appropriate registers so that code downstream can use them without
having to interpret the bits.

The ramification of this is that recently obtained data (last few days) will have a
BOR record with a format inconsistent with this. Thus, the
code will misinterpret it, giving bogus values. My assumption is
that, given the additional delays we heard about this morning, the cosmic
data taken over the last several days can be easily replaced.

I will implement this today so we take cosmics overnight with what is hopefully
the final BOR format. If there are strong objections to this plan, please let me
know ASAP.

Regards,
-David