[Halld-offline] reconstruction problem in master branch of sim-recon

[Naomi Jarvis]

Anyone looking at the newest (less than a week old) data will need some of
the updates made since 2.20.1 to read the CDC data.

The permanent fixes to enable this were were in a few pull requests from
David & Sean.   I think these were davidl_CDC_pulse_peak and
sdobbs_fix_cdc_confusion.  There might have been one more.  David & Sean:
?????

If the history for these is tangled up with the matching routines then
there's also my earlier fix in nsj_CDC_readout_oldparser_fix which was
never merged.  It does the same thing (reading the CDC data into CDCPulse)
in a less elegant way and precedes including amp in digihits.  This might
be an interim solution if anyone needs one.

Naomi.


On 22 December 2017 at 11:01, Mark Ito <marki at jlab.org> wrote:

> Folks,
>
> As mentioned at the analysis meeting on Wednesday, there is an issue with
> the master branch of sim-recon that causes reduced efficiency for photon
> reconstruction in the FCAL:
>
> https://halldweb.jlab.org/wiki-private/index.php/December_
> 20,_2017,_Analysis_Working_Group#Minutes
>
> Since then Alex has identified a major set of changes to the matching
> routines as the cause of the problem. These were introduced with pull
> request #1008:
>
>   https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1008&d=DwIBaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=oyKV5joTkJsuRYv6hh48IMTw3i-IrYD-ZUAHHU0DdAY&m=z7mFcyUUETz03zGzowX-S6OM7QAgdPujVm0_iJx3hQI&s=8IrWaskVeu_80hbmVff4rDmmp4GLOqDmn6WZGlBEI0c&e= 
>
> With the holiday break upon us, there is no plan to institute some sort of
> quick fix. The latest tagged release:
>
>   https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_releases_tag_2.20.1&d=DwIBaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=oyKV5joTkJsuRYv6hh48IMTw3i-IrYD-ZUAHHU0DdAY&m=z7mFcyUUETz03zGzowX-S6OM7QAgdPujVm0_iJx3hQI&s=78HXiZc0jNQFB7Q2-R-XbJjusNTa7CF0BAiB_OoBsHE&e= 
>
> pre-dates the change and can be used as a fall-back.
>
> If folks really need a "fixed" version, let me know and we can discuss
> options.
>
>   -- Mark
>
> --
> Mark Ito, marki at jlab.org, (757)269-5295
>
> _______________________________________________
> Halld-offline mailing list
> Halld-offline at jlab.org
> https://mailman.jlab.org/mailman/listinfo/halld-offline
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.jlab.org/pipermail/halld-offline/attachments/20171222/a25d155a/attachment-0002.html>