[Halld-offline] Fwd: Re: Splitting sim-recon: push your changes by 5 pm today (Mon. July 30) [Re: push deadline postponed; new deadline to be discussed]

[Mark Ito]

Neglected to cc my response to Justin to the group...



-------- Forwarded Message --------
Subject: 	Re: [Halld-offline] Splitting sim-recon: push your changes by 
5 pm today (Mon. July 30) [Re: push deadline postponed; new deadline to 
be discussed]
Date: 	Tue, 31 Jul 2018 08:34:35 -0400
From: 	Mark Ito <marki at jlab.org>
To: 	Justin Stevens <jrsteven at jlab.org>



Justin,

On 07/31/2018 07:45 AM, Justin Stevens wrote:
>
> -The sim components have been removed from halld_recon, but halld_sim 
> seems to still have all the source code from halld_recon.  It seems 
> these recon libraries are not built in halld_sim, but you plan to 
> remove this duplicated code, right?
Yes that code should be deleted and I see that it is not. I know I
worked on that when we changed the scheme to preserve branches on the
sim side. I'll have to look to see what happened.
> -David’s recent changes to SBMS seem to have been backed out bythe 
> initial commits to both halld_recon and halld_sim.  I assume that was 
> by accident?
I have not looked yet, but there were versions of both of the two new
SBMS areas waiting in storage to be swapped in at split time. That had
the risk that as time went on they could go stale. That might be what
happened. That is why I commented that we should not merge that branch
until after the split, it was a worry. But again, I haven't looked.

Thanks for the comments; very helpful!

   -- Mark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.jlab.org/pipermail/halld-offline/attachments/20180731/ab049e36/attachment.html>