[Halld-offline] heads-up: pull requests require review for halld_recon and halld_sim

Mark Ito marki at jlab.org
Tue Apr 28 20:06:19 EDT 2020


Cool. Good to know.

On 4/28/20 7:59 PM, Justin Stevens wrote:
> FYI, just successfully executed the review -> merge PR sequence.  There’s basically just one more button to push to “Approve” the review, and then you can merge as usual.
> -Justin
>
>> On Apr 28, 2020, at 5:04 PM, Mark Ito <marki at jlab.org> wrote:
>>
>> Folks,
>>
>> At the software meeting just now, we decided to require "reviews" of pull requests before they can be merged onto the master branch. For now this is only for halld_sim and halld_recon. The webpages for the individual pull requests now reflect this. The idea is to prevent inadvertent changes to the master branches.
>>
>>    -- Mark
>>
>>
>> _______________________________________________
>> Halld-offline mailing list
>> Halld-offline at jlab.org
>> https://mailman.jlab.org/mailman/listinfo/halld-offline



More information about the Halld-offline mailing list