[Halld-offline] [EXTERNAL] Re: heads-up: pull requests require review for halld_recon and halld_sim

[Sean Dobbs]

At least the "make sure it compiles and runs" parts are done by the
automated build tests applied to every pull request.

There are different standards of peer review we could decide to
require (there is a lot of literature out there on on code reviews),
but I agree that requiring independent reproduction of results is a
higher hurdle than I would prefer.

---Sean

On Wed, Apr 29, 2020 at 9:30 AM Naomi Jarvis <nsj at cmu.edu> wrote:
>
> I thought the review process would be something like download the new branch, make sure it compiles, make sure it runs, make sure it does whatever it was supposed to do, then go to the website and click the merge button (and presumably one more now).  That's what I do before approving PRs (& why I don't approve many).
>
> Naomi.
>
> On Wed, Apr 29, 2020 at 9:00 AM Sean Dobbs <sdobbs at fsu.edu> wrote:
>>
>> We could just start with a short comment like “looks good” for now, and then revisit the question next software meeting when more people are familiar with what functionality is available.
>>
>> Cheers
>> Sean
>>
>> On Wed, Apr 29, 2020 at 8:46 AM Mark Ito <marki at jlab.org> wrote:
>>>
>>> Mark,
>>>
>>> That is a good point, well taken. Anyone who was at the meeting
>>> yesterday care to take this one?
>>>
>>>    -- Mark
>>>
>>> On 4/29/20 8:08 AM, Mark-Macrae Dalton wrote:
>>> > It might be useful to spell out more clearly what is expected from a review of a pull request, other than clicking the button.
>>> >
>>> > Mark
>>> >
>>> >> On Apr 28, 2020, at 8:06 PM, Mark Ito <marki at jlab.org> wrote:
>>> >>
>>> >> Cool. Good to know.
>>> >>
>>> >> On 4/28/20 7:59 PM, Justin Stevens wrote:
>>> >>> FYI, just successfully executed the review -> merge PR sequence.  There’s basically just one more button to push to “Approve” the review, and then you can merge as usual.
>>> >>> -Justin
>>> >>>
>>> >>>> On Apr 28, 2020, at 5:04 PM, Mark Ito <marki at jlab.org> wrote:
>>> >>>>
>>> >>>> Folks,
>>> >>>>
>>> >>>> At the software meeting just now, we decided to require "reviews" of pull requests before they can be merged onto the master branch. For now this is only for halld_sim and halld_recon. The webpages for the individual pull requests now reflect this. The idea is to prevent inadvertent changes to the master branches.
>>> >>>>
>>> >>>>    -- Mark
>>> >>>>
>>> >>>>
>>> >>>> _______________________________________________
>>> >>>> Halld-offline mailing list
>>> >>>> Halld-offline at jlab.org
>>> >>>> https://mailman.jlab.org/mailman/listinfo/halld-offline
>>> >> _______________________________________________
>>> >> Halld-offline mailing list
>>> >> Halld-offline at jlab.org
>>> >> https://mailman.jlab.org/mailman/listinfo/halld-offline
>>> _______________________________________________
>>> Halld-offline mailing list
>>> Halld-offline at jlab.org
>>> https://mailman.jlab.org/mailman/listinfo/halld-offline
>>
>> _______________________________________________
>> Halld-offline mailing list
>> Halld-offline at jlab.org
>> https://mailman.jlab.org/mailman/listinfo/halld-offline