<div dir="ltr">Hi all,<div><br></div><div>One more update, I've uploaded a new branch for simulations corresponding to the latest reconstruction launch. The name of the branch is:</div><div><br></div><div>recon-2017_01-ver02-sim</div><div><br></div><div>and pulls in a few simulation-related changes that have hit the master since production.</div><div><br></div><div>I've verified that it compiles OK, but it would be nice if some other experts could sanity check that this branch gives reasonable results.</div><div><br></div><div>Happy holidays,</div><div>Sean<br><br><div class="gmail_quote"><div dir="ltr">On Fri, Dec 22, 2017 at 1:53 PM Sean Dobbs <<a href="mailto:sdobbs@fsu.edu" target="_blank">sdobbs@fsu.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi all,<div><br></div><div>For those who are interested in trying this out, I've added a branch named "recon_2018-01_ver00", which is forked from the current master, but with the pull request bringing in Simon's matching changes reverted. </div><div><br></div><div>Note that I did have to fix a merge conflict, so it would be nice to check to see that this branch gives reasonable results.</div><div><br></div><div>For the cognoscenti: </div><div><br></div><div>The command I used on this branch was:</div><div>git revert -m 1 171c380cfe73e91963e471c750484f2257a36d75</div><div><br></div><div>where the hash was from the commit that merged in the PR.</div><div><br></div><div>Cheers,</div><div>Sean</div></div><div dir="ltr"><div><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Dec 22, 2017 at 12:09 PM Naomi Jarvis <<a href="mailto:nsj@cmu.edu" target="_blank">nsj@cmu.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><blockquote type="cite" style="font-size:12.8px"><div dir="ltr">Anyone looking at the newest (less than a week old) data will need some of the updates made since 2.20.1 to read the CDC data. <div><br></div><div>The permanent fixes to enable this were were in a few pull requests from David & Sean. I think these were <span style="font-size:12.8px">davidl_CDC_pulse_peak and sdobbs_fix_cdc_confusion. There might have been one more. David & Sean: ?????</span></div><div><br></div><div>If the history for these is tangled up with the matching routines then there's also my earlier fix in nsj_CDC_readout_oldparser_fix which was never merged. It does the same thing (reading the CDC data into CDCPulse) in a less elegant way and precedes including amp in digihits. This might be an interim solution if anyone needs one. </div><div><br></div><div>Naomi.</div></div></blockquote></div><div class="gmail_extra"><br><div class="gmail_quote">On 22 December 2017 at 11:01, Mark Ito <span dir="ltr"><<a href="mailto:marki@jlab.org" target="_blank">marki@jlab.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Folks,<br>
<br>
As mentioned at the analysis meeting on Wednesday, there is an issue with the master branch of sim-recon that causes reduced efficiency for photon reconstruction in the FCAL:<br>
<br>
<a href="https://halldweb.jlab.org/wiki-private/index.php/December_20,_2017,_Analysis_Working_Group#Minutes" rel="noreferrer" target="_blank">https://halldweb.jlab.org/wiki-private/index.php/December_20,_2017,_Analysis_Working_Group#Minutes</a><br>
<br>
Since then Alex has identified a major set of changes to the matching routines as the cause of the problem. These were introduced with pull request #1008:<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1008&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=oyKV5joTkJsuRYv6hh48IMTw3i-IrYD-ZUAHHU0DdAY&m=z7mFcyUUETz03zGzowX-S6OM7QAgdPujVm0_iJx3hQI&s=8IrWaskVeu_80hbmVff4rDmmp4GLOqDmn6WZGlBEI0c&e=" rel="noreferrer" target="_blank">https://github.com/JeffersonLab/sim-recon/pull/1008</a><br>
<br>
With the holiday break upon us, there is no plan to institute some sort of quick fix. The latest tagged release:<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_releases_tag_2.20.1&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=oyKV5joTkJsuRYv6hh48IMTw3i-IrYD-ZUAHHU0DdAY&m=z7mFcyUUETz03zGzowX-S6OM7QAgdPujVm0_iJx3hQI&s=78HXiZc0jNQFB7Q2-R-XbJjusNTa7CF0BAiB_OoBsHE&e=" rel="noreferrer" target="_blank">https://github.com/JeffersonLab/sim-recon/releases/tag/2.20.1</a><br>
<br>
pre-dates the change and can be used as a fall-back.<br>
<br>
If folks really need a "fixed" version, let me know and we can discuss options.<span class="m_5271648133524788585m_1296333576821144110m_-8574261062364953052HOEnZb"><font color="#888888"><br>
<br>
-- Mark<br>
<br>
-- <br>
Mark Ito, <a href="mailto:marki@jlab.org" target="_blank">marki@jlab.org</a>, <a href="tel:%28757%29269-5295" value="+17572695295" target="_blank">(757)269-5295</a><br>
<br>
_______________________________________________<br>
Halld-offline mailing list<br>
<a href="mailto:Halld-offline@jlab.org" target="_blank">Halld-offline@jlab.org</a><br>
<a href="https://mailman.jlab.org/mailman/listinfo/halld-offline" rel="noreferrer" target="_blank">https://mailman.jlab.org/mailman/listinfo/halld-offline</a></font></span></blockquote></div><br></div>
_______________________________________________<br>
Halld-offline mailing list<br>
<a href="mailto:Halld-offline@jlab.org" target="_blank">Halld-offline@jlab.org</a><br>
<a href="https://mailman.jlab.org/mailman/listinfo/halld-offline" rel="noreferrer" target="_blank">https://mailman.jlab.org/mailman/listinfo/halld-offline</a></blockquote></div></div></div></blockquote></div></div></div>