<div dir="ltr">Or how about just emailing the author and asking, have you done this? Or can you do this one more test, and I will approve it. Something like the way peer review of articles works. Usually the reviewer does not download the data and carry out independent checks of the results.<div><br></div><div>-rtj</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 29, 2020 at 9:37 AM Naomi Jarvis <<a href="mailto:nsj@cmu.edu">nsj@cmu.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p></p>
<div style="background-color:rgb(255,235,156);width:100%;border-style:none;border-color:rgb(250,235,204);border-width:1pt;padding:10pt;font-size:11pt;line-height:12pt;font-family:Calibri;color:rgb(0,0,0);text-align:left">
<span style="color:rgb(156,101,0)"></span>*Message sent from a system outside of UConn.*</div>
<br>
<p></p>
<div>
<div dir="ltr">I thought the review process would be something like download the new branch, make sure it compiles, make sure it runs, make sure it does whatever it was supposed to do, then go to the website and click the merge button (and presumably one more
now). That's what I do before approving PRs (& why I don't approve many).
<div><br>
</div>
<div>Naomi. </div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Apr 29, 2020 at 9:00 AM Sean Dobbs <<a href="mailto:sdobbs@fsu.edu" target="_blank">sdobbs@fsu.edu</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<div dir="auto">We could just start with a short comment like “looks good” for now, and then revisit the question next software meeting when more people are familiar with what functionality is available. </div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">Cheers</div>
<div dir="auto">Sean</div>
<div><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Apr 29, 2020 at 8:46 AM Mark Ito <<a href="mailto:marki@jlab.org" target="_blank">marki@jlab.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Mark,<br>
<br>
That is a good point, well taken. Anyone who was at the meeting <br>
yesterday care to take this one?<br>
<br>
-- Mark<br>
<br>
On 4/29/20 8:08 AM, Mark-Macrae Dalton wrote:<br>
> It might be useful to spell out more clearly what is expected from a review of a pull request, other than clicking the button.<br>
><br>
> Mark<br>
><br>
>> On Apr 28, 2020, at 8:06 PM, Mark Ito <<a href="mailto:marki@jlab.org" target="_blank">marki@jlab.org</a>> wrote:<br>
>><br>
>> Cool. Good to know.<br>
>><br>
>> On 4/28/20 7:59 PM, Justin Stevens wrote:<br>
>>> FYI, just successfully executed the review -> merge PR sequence. There’s basically just one more button to push to “Approve” the review, and then you can merge as usual.<br>
>>> -Justin<br>
>>><br>
>>>> On Apr 28, 2020, at 5:04 PM, Mark Ito <<a href="mailto:marki@jlab.org" target="_blank">marki@jlab.org</a>> wrote:<br>
>>>><br>
>>>> Folks,<br>
>>>><br>
>>>> At the software meeting just now, we decided to require "reviews" of pull requests before they can be merged onto the master branch. For now this is only for halld_sim and halld_recon. The webpages for the individual pull requests now reflect this. The
idea is to prevent inadvertent changes to the master branches.<br>
>>>><br>
>>>> -- Mark<br>
>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> Halld-offline mailing list<br>
>>>> <a href="mailto:Halld-offline@jlab.org" target="_blank">Halld-offline@jlab.org</a><br>
>>>> <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__nam10.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fmailman.jlab.org-252Fmailman-252Flistinfo-252Fhalld-2Doffline-26data-3D02-257C01-257Crichard.t.jones-2540uconn.edu-257C27fd9227d73c4da2c00a08d7ec41b3d3-257C17f1a87e2a254eaab9df9d439034b080-257C0-257C0-257C637237639251846251-26sdata-3DgkJIGEsJ703IQhrHeWKZ-252FMkMnKATp4BMnhUAJVqvY2A-253D-26reserved-3D0&d=DwMFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=Te_hCR4EUlJ6iCDYLJ8Viv2aDOR7D9ZZMoBAvf2H0M4&m=s1rydy2wtTm4oNwi0LnpZYCnXrxxs7xi6nYvhktvqrw&s=Uo92_uGUaoF8XYALdVBVoyrm-crKFl56IQgWHhHVHVU&e=" rel="noreferrer" target="_blank">
https://mailman.jlab.org/mailman/listinfo/halld-offline</a><br>
>> _______________________________________________<br>
>> Halld-offline mailing list<br>
>> <a href="mailto:Halld-offline@jlab.org" target="_blank">Halld-offline@jlab.org</a><br>
>> <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__nam10.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fmailman.jlab.org-252Fmailman-252Flistinfo-252Fhalld-2Doffline-26data-3D02-257C01-257Crichard.t.jones-2540uconn.edu-257C27fd9227d73c4da2c00a08d7ec41b3d3-257C17f1a87e2a254eaab9df9d439034b080-257C0-257C0-257C637237639251846251-26sdata-3DgkJIGEsJ703IQhrHeWKZ-252FMkMnKATp4BMnhUAJVqvY2A-253D-26reserved-3D0&d=DwMFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=Te_hCR4EUlJ6iCDYLJ8Viv2aDOR7D9ZZMoBAvf2H0M4&m=s1rydy2wtTm4oNwi0LnpZYCnXrxxs7xi6nYvhktvqrw&s=Uo92_uGUaoF8XYALdVBVoyrm-crKFl56IQgWHhHVHVU&e=" rel="noreferrer" target="_blank">
https://mailman.jlab.org/mailman/listinfo/halld-offline</a><br>
_______________________________________________<br>
Halld-offline mailing list<br>
<a href="mailto:Halld-offline@jlab.org" target="_blank">Halld-offline@jlab.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__nam10.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fmailman.jlab.org-252Fmailman-252Flistinfo-252Fhalld-2Doffline-26data-3D02-257C01-257Crichard.t.jones-2540uconn.edu-257C27fd9227d73c4da2c00a08d7ec41b3d3-257C17f1a87e2a254eaab9df9d439034b080-257C0-257C0-257C637237639251856246-26sdata-3D0acpsNjdYzHIez-252BvBUDisiD6Sj8p6oM78XUE685C98I-253D-26reserved-3D0&d=DwMFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=Te_hCR4EUlJ6iCDYLJ8Viv2aDOR7D9ZZMoBAvf2H0M4&m=s1rydy2wtTm4oNwi0LnpZYCnXrxxs7xi6nYvhktvqrw&s=uVv3yNkBzGPBbTo82Q8EhRnOB6xhe0NLTA_aK_-6WSM&e=" rel="noreferrer" target="_blank">https://mailman.jlab.org/mailman/listinfo/halld-offline</a></blockquote>
</div>
</div>
_______________________________________________<br>
Halld-offline mailing list<br>
<a href="mailto:Halld-offline@jlab.org" target="_blank">Halld-offline@jlab.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__nam10.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fmailman.jlab.org-252Fmailman-252Flistinfo-252Fhalld-2Doffline-26data-3D02-257C01-257Crichard.t.jones-2540uconn.edu-257C27fd9227d73c4da2c00a08d7ec41b3d3-257C17f1a87e2a254eaab9df9d439034b080-257C0-257C0-257C637237639251856246-26sdata-3D0acpsNjdYzHIez-252BvBUDisiD6Sj8p6oM78XUE685C98I-253D-26reserved-3D0&d=DwMFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=Te_hCR4EUlJ6iCDYLJ8Viv2aDOR7D9ZZMoBAvf2H0M4&m=s1rydy2wtTm4oNwi0LnpZYCnXrxxs7xi6nYvhktvqrw&s=uVv3yNkBzGPBbTo82Q8EhRnOB6xhe0NLTA_aK_-6WSM&e=" rel="noreferrer" target="_blank">https://mailman.jlab.org/mailman/listinfo/halld-offline</a></blockquote>
</div>
</div>
</div>
_______________________________________________<br>
Halld-offline mailing list<br>
<a href="mailto:Halld-offline@jlab.org" target="_blank">Halld-offline@jlab.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__nam10.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fmailman.jlab.org-252Fmailman-252Flistinfo-252Fhalld-2Doffline-26amp-3Bdata-3D02-257C01-257Crichard.t.jones-2540uconn.edu-257C27fd9227d73c4da2c00a08d7ec41b3d3-257C17f1a87e2a254eaab9df9d439034b080-257C0-257C0-257C637237639251886232-26amp-3Bsdata-3DdoNOCLzRPLj59h9l4LLjZ04WFccf2s7KPmLa0vXRHEs-253D-26amp-3Breserved-3D0&d=DwMFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=Te_hCR4EUlJ6iCDYLJ8Viv2aDOR7D9ZZMoBAvf2H0M4&m=s1rydy2wtTm4oNwi0LnpZYCnXrxxs7xi6nYvhktvqrw&s=6e6-OfuqOOge3abxyj5Vicwdfy_vI-t762D8-aTxNxY&e=" rel="noreferrer" target="_blank">https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmailman.jlab.org%2Fmailman%2Flistinfo%2Fhalld-offline&data=02%7C01%7Crichard.t.jones%40uconn.edu%7C27fd9227d73c4da2c00a08d7ec41b3d3%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C0%7C637237639251886232&sdata=doNOCLzRPLj59h9l4LLjZ04WFccf2s7KPmLa0vXRHEs%3D&reserved=0</a></blockquote></div>