<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;color:rgb(68,68,68)"><div class="gmail_default" style="font-size:12.8px">A few comments: </div><div class="gmail_default" style="font-size:12.8px"><br></div><div class="gmail_default" style="font-size:12.8px">1) I'm confused, the conditions record that cause this problem was modified in December of 2016. However, <span id="gmail-m_7479769853163263060:2pi.1">Rafo</span> found a log file that shows this issue was present in October of 2016. This is strange.</div><div class="gmail_default" style="font-size:12.8px">2) I'm not sure why the timestamp is being used, but the rest of the conditions code should be checked to make sure the disambiguation is being done in a reasonable way. The only reason the rest of the conditions weren't affected is because they weren't updated. However, if the disambiguation is being done in the same manner, then we may see this issue with other conditions in the future. Jeremy wrote most of the code so it's probably easy for him to check this. If the same issue exist for other conditions sets, we should fix before we run pass1.</div><div class="gmail_default" style="font-size:12.8px">3) We should check that the correct conditions were used for 2015 Pass 6. The log file from October 2016 has me worried that we might have used the wrong conditions for previous passes. </div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 23, 2017 at 9:19 PM, Omar Moreno <span dir="ltr"><<a href="mailto:email@omarmoreno.net" target="_blank">email@omarmoreno.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;color:#444444">A few comments: </div><div class="gmail_default" style="font-family:verdana,sans-serif;color:#444444"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif;color:#444444">1) I'm confused, the conditions record that cause this problem was modified in December of 2016. However, <span id="m_2054207135731572910:2pi.1">Rafo</span> found a log file that shows this issue was present in October of 2016. This is strange.</div><div class="gmail_default" style="font-family:verdana,sans-serif;color:#444444">2) I'm not sure why the timestamp is being used, but the rest of the conditions code should be checked to make sure the disambiguation is being done in a reasonable way. The only reason the rest of the conditions weren't affected is because they weren't updated. However, if the disambiguation is being done in the same manner, then we may see this issue with other conditions in the future. Jeremy wrote most of the code so it's probably easy for him to check this. If the same issue exist for other conditions sets, we should fix before we run pass1.</div><div class="gmail_default" style="font-family:verdana,sans-serif;color:#444444">3) We should check that the correct conditions were used for 2015 Pass 6. The log file from October 2016 has me worried that we might have used the wrong conditions for previous passes. </div><div class="gmail_default" style="font-family:verdana,sans-serif;color:#444444"><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 23, 2017 at 8:29 PM, Graf, Norman A. <span dir="ltr"><<a href="mailto:ngraf@slac.stanford.edu" target="_blank">ngraf@slac.stanford.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr" style="font-size:12pt;color:#000000;background-color:#ffffff;font-family:Calibri,Arial,Helvetica,sans-serif">
<p>even better.<br>
</p>
<div style="color:rgb(33,33,33)">
<hr style="display:inline-block;width:98%">
<div id="m_2054207135731572910m_5066406381679483598divRplyFwdMsg" dir="ltr"><font color="#000000" face="Calibri, sans-serif" style="font-size:11pt"><b>From:</b> McCormick, Jeremy I.<br>
<b>Sent:</b> Tuesday, May 23, 2017 6:52 PM<br>
<b>To:</b> Graham, Mathew Thomas<span><br>
<b>Cc:</b> Rafayel Paremuzyan; Graf, Norman A.; Omar Moreno; <a href="mailto:hps-analysis@jlab.org" target="_blank">hps-analysis@jlab.org</a>; hps-software<br>
</span><b>Subject:</b> RE: [Hps-analysis] Test pass1 Status</font>
<div> </div>
</div><div><div class="m_2054207135731572910h5">
<div>
<div class="m_2054207135731572910m_5066406381679483598WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Hi,</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Conditions for reconstruction passes should always be tagged to avoid exactly these kinds of issues. We have had this capability for a long time and it should be part of
the process of preparing the pass. It used to be and I don’t know why we stopped doing this…</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">So please can we make a “pass1_2016” tag with all the conditions sets we want to use for pass1 in order that this doesn’t happen again?</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">I’m not sure if we want to make one retroactively for pass0 but it wouldn’t be a bad idea.
</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">--Jeremy</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p>
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Graham, Mathew Thomas
<br>
<b>Sent:</b> Tuesday, May 23, 2017 6:38 PM<br>
<b>To:</b> McCormick, Jeremy I.<br>
<b>Cc:</b> Rafayel Paremuzyan; Graf, Norman A.; Omar Moreno; <a href="mailto:hps-analysis@jlab.org" target="_blank">hps-analysis@jlab.org</a>; hps-software<br>
<b>Subject:</b> Re: [Hps-analysis] Test pass1 Status</span></p>
</div>
</div>
<p class="MsoNormal"> </p>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="background:white"><span style="font-size:9.0pt;font-family:"Helvetica","sans-serif""> </span></p>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">For the future though we will change the code so it disambiguates overlapping run ranges by using the conditions set that was most recently created.
That’s the default for most conditions anyways.</span></p>
</div>
</blockquote>
<div>
<p class="MsoNormal"> </p>
</div>
<div>
<p class="MsoNormal">Nah, I think there should be some sort of pseudo-tag like “best_calibration_constants”, so that we don’t have to just assume that the last set entered for a run range are the set that should be used. </p>
</div>
</div>
</div>
</div>
</div></div></div>
</div>
<br><div class="m_2054207135731572910HOEnZb"><div class="m_2054207135731572910h5">
<hr>
<p align="left">
Use REPLY-ALL to reply to list</p>
<p align="center">To unsubscribe from the HPS-SOFTWARE list, click the following link:<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__listserv.slac.stanford.edu_cgi-2Dbin_wa-3FSUBED1-3DHPS-2DSOFTWARE-26A-3D1&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=J4PP6Zl8IyGHpsqWaKegORCYw8hoCHePTw5O95a5lqQ&m=qnoDNf-CBHFsM3Eiz9vqQkSMh_N8INSoFrARkTUQz_U&s=vsirEK3_V1PKM-plRyAzgKC31kgytKXNCjFvkOEouzQ&e=" target="_blank">https://listserv.slac.stanford<wbr>.edu/cgi-bin/wa?SUBED1=HPS-<wbr>SOFTWARE&A=1</a>
</p>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>