<html>
<head>
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<div class="">Hey, Omar.</div>
<div class=""><br class="">
</div>
<div class="">There’s four ways available to deal with multiple conditions being found for the same type …</div>
<div class=""><br class="">
</div>
<div class="">- Throw an error.</div>
<div class=""><br class="">
</div>
<div class="">- Use the last one created.</div>
<div class=""><br class="">
</div>
<div class="">- Use the last one updated.</div>
<div class=""><br class="">
</div>
<div class="">- Use the one with the largest run start number.</div>
<div class=""><br class="">
</div>
<div class="">If you want to add more ways to do this it is certainly possible.</div>
<div class=""><br class="">
</div>
<div class="">Probably we should make a good default tag based on what we have now (which seems pretty stable) and then encourage people to use that when running jobs so that this would mostly be a non-issue.</div>
<div class=""><br class="">
</div>
<div class="">—Jeremy</div>
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On May 23, 2017, at 11:15 PM, Omar Moreno <<a href="mailto:omoreno1@ucsc.edu" class="">omoreno1@ucsc.edu</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><br class="Apple-interchange-newline">
<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
On Tue, May 23, 2017 at 11:13 PM, McCormick, Jeremy I.<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:jeremym@slac.stanford.edu" target="_blank" class="">jeremym@slac.stanford.edu</a>></span><span class="Apple-converted-space"> </span>wrote:<br class="">
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div style="word-wrap: break-word;" class="">
<div class="">Several of the SVT conditions classes are using the strategy of looking at the update date to disambiguate between overlapping conditions, which is set via markup on the class. You can go ahead and change that to creation date if you want that
to be used instead.</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="gmail_default" style="font-family: verdana, sans-serif; color: rgb(68, 68, 68);">
I'm not sure using the creation date is the right strategy either. Let me think about this a bit ...</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div style="word-wrap: break-word;" class="">
<div class=""><br class="">
</div>
<div class="">For passes, the only reasonable way to do this is using tags. Otherwise, you would rely on a particular un-tagged conditions configuration that might change later and affect the recon results.</div>
<div class="">
<div class="h5">
<div class=""><br class="">
</div>
<div class="">
<blockquote type="cite" class="">
<div class="">On May 23, 2017, at 9:23 PM, Omar Moreno <<a href="mailto:omoreno1@ucsc.edu" target="_blank" class="">omoreno1@ucsc.edu</a>> wrote:</div>
<br class="m_-3657596841969813362Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">
<div style="font-family: verdana, sans-serif; color: rgb(68, 68, 68);" class="">
<div style="font-size: 12.8px;" class="">A few comments: </div>
<div style="font-size: 12.8px;" class=""><br class="">
</div>
<div style="font-size: 12.8px;" class="">1) I'm confused, the conditions record that cause this problem was modified in December of 2016. However, <span id="m_-3657596841969813362gmail-m_7479769853163263060:2pi.1" class="">Rafo</span> found a log file that
shows this issue was present in October of 2016. This is strange.</div>
<div style="font-size: 12.8px;" class="">2) I'm not sure why the timestamp is being used, but the rest of the conditions code should be checked to make sure the disambiguation is being done in a reasonable way. The only reason the rest of the conditions weren't
affected is because they weren't updated. However, if the disambiguation is being done in the same manner, then we may see this issue with other conditions in the future. Jeremy wrote most of the code so it's probably easy for him to check this. If the
same issue exist for other conditions sets, we should fix before we run pass1.</div>
<div style="font-size: 12.8px;" class="">3) We should check that the correct conditions were used for 2015 Pass 6. The log file from October 2016 has me worried that we might have used the wrong conditions for previous passes. </div>
</div>
</div>
<div class="gmail_extra"><br class="">
<div class="gmail_quote">On Tue, May 23, 2017 at 9:19 PM, Omar Moreno<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:email@omarmoreno.net" target="_blank" class="">email@omarmoreno.net</a>></span><span class="Apple-converted-space"> </span>wrote:<br class="">
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div dir="ltr" class="">
<div style="font-family: verdana, sans-serif; color: rgb(68, 68, 68);" class="">A few comments: </div>
<div style="font-family: verdana, sans-serif; color: rgb(68, 68, 68);" class=""><br class="">
</div>
<div style="font-family: verdana, sans-serif; color: rgb(68, 68, 68);" class="">1) I'm confused, the conditions record that cause this problem was modified in December of 2016. However,<span id="m_-3657596841969813362m_2054207135731572910:2pi.1" class="">Rafo</span><span class="Apple-converted-space"> </span>found
a log file that shows this issue was present in October of 2016. This is strange.</div>
<div style="font-family: verdana, sans-serif; color: rgb(68, 68, 68);" class="">2) I'm not sure why the timestamp is being used, but the rest of the conditions code should be checked to make sure the disambiguation is being done in a reasonable way. The only
reason the rest of the conditions weren't affected is because they weren't updated. However, if the disambiguation is being done in the same manner, then we may see this issue with other conditions in the future. Jeremy wrote most of the code so it's probably
easy for him to check this. If the same issue exist for other conditions sets, we should fix before we run pass1.</div>
<div style="font-family: verdana, sans-serif; color: rgb(68, 68, 68);" class="">3) We should check that the correct conditions were used for 2015 Pass 6. The log file from October 2016 has me worried that we might have used the wrong conditions for previous
passes. </div>
<div style="font-family: verdana, sans-serif; color: rgb(68, 68, 68);" class=""><br class="">
</div>
</div>
<div class="m_-3657596841969813362HOEnZb">
<div class="m_-3657596841969813362h5">
<div class="gmail_extra"><br class="">
<div class="gmail_quote">On Tue, May 23, 2017 at 8:29 PM, Graf, Norman A.<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:ngraf@slac.stanford.edu" target="_blank" class="">ngraf@slac.stanford.edu</a>></span><span class="Apple-converted-space"> </span>wrote:<br class="">
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div dir="ltr" style="font-size: 12pt; background-color: rgb(255, 255, 255); font-family: Calibri, Arial, Helvetica, sans-serif;" class="">
<p class="">even better.<br class="">
</p>
<div style="color: rgb(33, 33, 33);" class="">
<hr style="display: inline-block; width: 665.5625px;" class="">
<div id="m_-3657596841969813362m_2054207135731572910m_5066406381679483598divRplyFwdMsg" dir="ltr" class="">
<font face="Calibri, sans-serif" style="font-size: 11pt;" class=""><b class="">From:</b><span class="Apple-converted-space"> </span>McCormick, Jeremy I.<br class="">
<b class="">Sent:</b><span class="Apple-converted-space"> </span>Tuesday, May 23, 2017 6:52 PM<br class="">
<b class="">To:</b><span class="Apple-converted-space"> </span>Graham, Mathew Thomas<span class=""><br class="">
<b class="">Cc:</b><span class="Apple-converted-space"> </span>Rafayel Paremuzyan; Graf, Norman A.; Omar Moreno;<span class="Apple-converted-space"> </span><a href="mailto:hps-analysis@jlab.org" target="_blank" class="">hps-analysis@jlab.org</a>; hps-software<br class="">
</span><b class="">Subject:</b><span class="Apple-converted-space"> </span>RE: [Hps-analysis] Test pass1 Status</font>
<div class=""> </div>
</div>
<div class="">
<div class="m_-3657596841969813362m_2054207135731572910h5">
<div class="">
<div class="m_-3657596841969813362m_2054207135731572910m_5066406381679483598WordSection1">
<p class="MsoNormal"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Hi,</span></p>
<div class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""> </span><br class="m_-3657596841969813362webkit-block-placeholder">
</div>
<p class="MsoNormal"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Conditions for reconstruction passes should always be tagged to avoid exactly these kinds of issues. We have had this capability for a long time and it should be
part of the process of preparing the pass. It used to be and I don’t know why we stopped doing this…</span></p>
<div class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""> </span><br class="m_-3657596841969813362webkit-block-placeholder">
</div>
<p class="MsoNormal"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">So please can we make a “pass1_2016” tag with all the conditions sets we want to use for pass1 in order that this doesn’t happen again?</span></p>
<div class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""> </span><br class="m_-3657596841969813362webkit-block-placeholder">
</div>
<p class="MsoNormal"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">I’m not sure if we want to make one retroactively for pass0 but it wouldn’t be a bad idea.</span></p>
<div class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class=""> </span><br class="m_-3657596841969813362webkit-block-placeholder">
</div>
<p class="MsoNormal"><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">--Jeremy</span></p>
<div class=""><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);" class=""> </span><br class="m_-3657596841969813362webkit-block-placeholder">
</div>
<div class="">
<div style="border-style: solid none none; border-top-color: rgb(181, 196, 223); border-top-width: 1pt; padding: 3pt 0in 0in;" class="">
<p class="MsoNormal"><b class=""><span style="font-size: 10pt; font-family: Tahoma, sans-serif;" class="">From:</span></b><span style="font-size: 10pt; font-family: Tahoma, sans-serif;" class=""><span class="Apple-converted-space"> </span>Graham, Mathew Thomas<span class="Apple-converted-space"> </span><br class="">
<b class="">Sent:</b><span class="Apple-converted-space"> </span>Tuesday, May 23, 2017 6:38 PM<br class="">
<b class="">To:</b><span class="Apple-converted-space"> </span>McCormick, Jeremy I.<br class="">
<b class="">Cc:</b><span class="Apple-converted-space"> </span>Rafayel Paremuzyan; Graf, Norman A.; Omar Moreno;<span class="Apple-converted-space"> </span><a href="mailto:hps-analysis@jlab.org" target="_blank" class="">hps-analysis@jlab.org</a>; hps-software<br class="">
<b class="">Subject:</b><span class="Apple-converted-space"> </span>Re: [Hps-analysis] Test pass1 Status</span></p>
</div>
</div>
<div class=""> <br class="m_-3657596841969813362webkit-block-placeholder">
</div>
<div class="">
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class="">
<div style="background-color: white;" class=""><span style="font-size: 9pt; font-family: Helvetica, sans-serif;" class=""> </span><br class="m_-3657596841969813362webkit-block-placeholder">
</div>
<div class="">
<p class="MsoNormal" style="background-color: white; background-position: initial initial; background-repeat: initial initial;">
<span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">For the future though we will change the code so it disambiguates overlapping run ranges by using the conditions set that was most recently created. That’s the default for most conditions
anyways.</span></p>
</div>
</blockquote>
<div class="">
<div class=""> <br class="m_-3657596841969813362webkit-block-placeholder">
</div>
</div>
<div class="">
<p class="MsoNormal">Nah, I think there should be some sort of pseudo-tag like “best_calibration_constants”, so that we don’t have to just assume that the last set entered for a run range are the set that should be used. </p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br class="">
<div class="m_-3657596841969813362m_2054207135731572910HOEnZb">
<div class="m_-3657596841969813362m_2054207135731572910h5">
<hr class="">
<p align="left" class="">Use REPLY-ALL to reply to list</p>
<p align="center" class="">To unsubscribe from the HPS-SOFTWARE list, click the following link:<br class="">
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__listserv.slac.stanford.edu_cgi-2Dbin_wa-3FSUBED1-3DHPS-2DSOFTWARE-26A-3D1&d=DwMGaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=J4PP6Zl8IyGHpsqWaKegORCYw8hoCHePTw5O95a5lqQ&m=f-fq5m6L7n6WwYsUwLH0xfE9sXAGYK1EbGce_4Pigow&s=loos6u9yCZLOJvchxEQ1lFqyprdAa34KXfrbTj5CKGc&e=" target="_blank" class="">https://listserv.slac.stanford<wbr class="">.edu/cgi-bin/wa?SUBED1=HPS-SOF<wbr class="">TWARE&A=1</a></p>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
<br class="">
</body>
</html>