[Clas_offline] Bug in CLAS-6 MC ST reconstruction (C++ code only)

[Johann Goetz]

Hi Paul,
I hope it not too much to ask that you make a branch in the repository and
check in your changes there. I would then be willing to merge these changes
into the trunk after I run my own tests with a1c.

-- Johann <https://sites.google.com/site/theodoregoetz/>


On Tue, Apr 29, 2014 at 11:47 AM, Paul Mattione <pmatt at jlab.org> wrote:

> Is anyone planning on fixing this?
>
>  - Paul
>
> On Apr 11, 2014, at 3:51 PM, Paul Mattione wrote:
>
> > I've found a bug in the C++ version of the new start counter
> reconstruction code for CLAS-6.  It only effects reconstruction of Monte
> Carlo data: ST hits are being reconstructed using the calibration constants
> from the run number in the HEAD bank rather than run number 1 (resulting in
> hit times that were off by ~700 ns).
> >
> > I modified my personal reconstruction code to use separate run #'s for
> the ST geometry and calibration constants, but reconstruction crashes
> because no calibration constants have ever been defined for runs 1-10 for
> some of the constants that are only needed by the C++ reconstruction code
> (e.g. STN_CALIB / adc2edep / reg1limit, needed by SThit::GetEnergyDeposit()
> in st/stpp_SThit.cc).
> >
> > Could someone with advanced knowledge of the start counter simulation
> and reconstruction codes set the missing calibration constants for runs
> 1-10?
> >
> > Until this is fixed, I recommend running your Monte Carlo simulations
> using the Fortran reconstruction code ("set st_type 1;" in your tcl file).
> >
> > - Paul
> >
> > FOR DEVELOPERS:
> >
> > My code modifications to use separate run #'s for the ST geometry and
> calibration constants can be found on ifarm1102 at (note that this is
> g13-era svn/scons software, so a straight copy may break your build):
> >
> > Code: /w/hallb/clasg13/pmatt/svnroot_clas6/g13a_pass2v2_64bit/trunk/
> > Environment Variables: /home/pmatt/env_jlab_clas6_mccook_centos62
> >
> > In this trunk, I made small modifications to the following files:
> >
> > detector/st/stpp_JCalibration.*
> > detector/st/st_brun.F
> > detector/st/stpp_initialize.cc
> > detector/st/stpp_STposition.*
> > calibration/tag_calib/tagraw.cxx
> >
> > If you want to test using your own source code, I recommend diff'ing
> these files with your current source code and only copying the changes that
> look related to this issue.  Thank you for helping with this.
> >
> >
> > _______________________________________________
> > Clas_offline mailing list
> > Clas_offline at jlab.org
> > https://mailman.jlab.org/mailman/listinfo/clas_offline
>
>
> _______________________________________________
> Clas_offline mailing list
> Clas_offline at jlab.org
> https://mailman.jlab.org/mailman/listinfo/clas_offline
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://mailman.jlab.org/pipermail/clas_offline/attachments/20140502/8ae861c1/attachment.html