[Halld-offline] New simulation branch
sdobbs at fsu.edu
Sat Dec 23 13:44:28 EST 2017
One more update, I've uploaded a new branch for simulations corresponding
to the latest reconstruction launch. The name of the branch is:
and pulls in a few simulation-related changes that have hit the master
I've verified that it compiles OK, but it would be nice if some other
experts could sanity check that this branch gives reasonable results.
On Fri, Dec 22, 2017 at 1:53 PM Sean Dobbs <sdobbs at fsu.edu> wrote:
> Hi all,
> For those who are interested in trying this out, I've added a branch named
> "recon_2018-01_ver00", which is forked from the current master, but with
> the pull request bringing in Simon's matching changes reverted.
> Note that I did have to fix a merge conflict, so it would be nice to check
> to see that this branch gives reasonable results.
> For the cognoscenti:
> The command I used on this branch was:
> git revert -m 1 171c380cfe73e91963e471c750484f2257a36d75
> where the hash was from the commit that merged in the PR.
> On Fri, Dec 22, 2017 at 12:09 PM Naomi Jarvis <nsj at cmu.edu> wrote:
>> Anyone looking at the newest (less than a week old) data will need some
>> of the updates made since 2.20.1 to read the CDC data.
>> The permanent fixes to enable this were were in a few pull requests from
>> David & Sean. I think these were davidl_CDC_pulse_peak and
>> sdobbs_fix_cdc_confusion. There might have been one more. David & Sean:
>> If the history for these is tangled up with the matching routines then
>> there's also my earlier fix in nsj_CDC_readout_oldparser_fix which was
>> never merged. It does the same thing (reading the CDC data into CDCPulse)
>> in a less elegant way and precedes including amp in digihits. This might
>> be an interim solution if anyone needs one.
>> On 22 December 2017 at 11:01, Mark Ito <marki at jlab.org> wrote:
>>> As mentioned at the analysis meeting on Wednesday, there is an issue
>>> with the master branch of sim-recon that causes reduced efficiency for
>>> photon reconstruction in the FCAL:
>>> Since then Alex has identified a major set of changes to the matching
>>> routines as the cause of the problem. These were introduced with pull
>>> request #1008:
>>> With the holiday break upon us, there is no plan to institute some sort
>>> of quick fix. The latest tagged release:
>>> pre-dates the change and can be used as a fall-back.
>>> If folks really need a "fixed" version, let me know and we can discuss
>>> -- Mark
>>> Mark Ito, marki at jlab.org, (757)269-5295
>>> Halld-offline mailing list
>>> Halld-offline at jlab.org
>> Halld-offline mailing list
>> Halld-offline at jlab.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Halld-offline