[Halld-offline] [EXTERNAL] Re: heads-up: pull requests require review for halld_recon and halld_sim

Wed Apr 29 10:32:20 EDT 2020

Or how about just emailing the author and asking, have you done this? Or
can you do this one more test, and I will approve it. Something like the
way peer review of articles works. Usually the reviewer does not download
the data and carry out independent checks of the results.

-rtj

On Wed, Apr 29, 2020 at 9:37 AM Naomi Jarvis <nsj at cmu.edu> wrote:

> *Message sent from a system outside of UConn.*
>
> I thought the review process would be something like download the new
> branch, make sure it compiles, make sure it runs, make sure it does
> whatever it was supposed to do, then go to the website and click the merge
> button (and presumably one more now).  That's what I do before approving
> PRs (& why I don't approve many).
>
> Naomi.
>
> On Wed, Apr 29, 2020 at 9:00 AM Sean Dobbs <sdobbs at fsu.edu> wrote:
>
>> We could just start with a short comment like “looks good” for now, and
>> then revisit the question next software meeting when more people are
>> familiar with what functionality is available.
>>
>> Cheers
>> Sean
>>
>> On Wed, Apr 29, 2020 at 8:46 AM Mark Ito <marki at jlab.org> wrote:
>>
>>> Mark,
>>>
>>> That is a good point, well taken. Anyone who was at the meeting
>>> yesterday care to take this one?
>>>
>>>    -- Mark
>>>
>>> On 4/29/20 8:08 AM, Mark-Macrae Dalton wrote:
>>> > It might be useful to spell out more clearly what is expected from a
>>> review of a pull request, other than clicking the button.
>>> >
>>> > Mark
>>> >
>>> >> On Apr 28, 2020, at 8:06 PM, Mark Ito <marki at jlab.org> wrote:
>>> >>
>>> >> Cool. Good to know.
>>> >>
>>> >> On 4/28/20 7:59 PM, Justin Stevens wrote:
>>> >>> FYI, just successfully executed the review -> merge PR sequence.
>>> There’s basically just one more button to push to “Approve” the review, and
>>> then you can merge as usual.
>>> >>> -Justin
>>> >>>
>>> >>>> On Apr 28, 2020, at 5:04 PM, Mark Ito <marki at jlab.org> wrote:
>>> >>>>
>>> >>>> Folks,
>>> >>>>
>>> >>>> At the software meeting just now, we decided to require "reviews"
>>> of pull requests before they can be merged onto the master branch. For now
>>> this is only for halld_sim and halld_recon. The webpages for the individual
>>> pull requests now reflect this. The idea is to prevent inadvertent changes
>>> to the master branches.
>>> >>>>
>>> >>>>    -- Mark
>>> >>>>
>>> >>>>
>>> >>>> _______________________________________________
>>> >>>> Halld-offline mailing list
>>> >>>> Halld-offline at jlab.org
>>> >>>> https://mailman.jlab.org/mailman/listinfo/halld-offline
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__nam10.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fmailman.jlab.org-252Fmailman-252Flistinfo-252Fhalld-2Doffline-26data-3D02-257C01-257Crichard.t.jones-2540uconn.edu-257C27fd9227d73c4da2c00a08d7ec41b3d3-257C17f1a87e2a254eaab9df9d439034b080-257C0-257C0-257C637237639251846251-26sdata-3DgkJIGEsJ703IQhrHeWKZ-252FMkMnKATp4BMnhUAJVqvY2A-253D-26reserved-3D0&d=DwIFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=Te_hCR4EUlJ6iCDYLJ8Viv2aDOR7D9ZZMoBAvf2H0M4&m=s1rydy2wtTm4oNwi0LnpZYCnXrxxs7xi6nYvhktvqrw&s=Uo92_uGUaoF8XYALdVBVoyrm-crKFl56IQgWHhHVHVU&e= >
>>> >> _______________________________________________
>>> >> Halld-offline mailing list
>>> >> Halld-offline at jlab.org
>>> >> https://mailman.jlab.org/mailman/listinfo/halld-offline
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__nam10.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fmailman.jlab.org-252Fmailman-252Flistinfo-252Fhalld-2Doffline-26data-3D02-257C01-257Crichard.t.jones-2540uconn.edu-257C27fd9227d73c4da2c00a08d7ec41b3d3-257C17f1a87e2a254eaab9df9d439034b080-257C0-257C0-257C637237639251846251-26sdata-3DgkJIGEsJ703IQhrHeWKZ-252FMkMnKATp4BMnhUAJVqvY2A-253D-26reserved-3D0&d=DwIFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=Te_hCR4EUlJ6iCDYLJ8Viv2aDOR7D9ZZMoBAvf2H0M4&m=s1rydy2wtTm4oNwi0LnpZYCnXrxxs7xi6nYvhktvqrw&s=Uo92_uGUaoF8XYALdVBVoyrm-crKFl56IQgWHhHVHVU&e= >
>>> _______________________________________________
>>> Halld-offline mailing list
>>> Halld-offline at jlab.org
>>> https://mailman.jlab.org/mailman/listinfo/halld-offline
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__nam10.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fmailman.jlab.org-252Fmailman-252Flistinfo-252Fhalld-2Doffline-26data-3D02-257C01-257Crichard.t.jones-2540uconn.edu-257C27fd9227d73c4da2c00a08d7ec41b3d3-257C17f1a87e2a254eaab9df9d439034b080-257C0-257C0-257C637237639251856246-26sdata-3D0acpsNjdYzHIez-252BvBUDisiD6Sj8p6oM78XUE685C98I-253D-26reserved-3D0&d=DwIFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=Te_hCR4EUlJ6iCDYLJ8Viv2aDOR7D9ZZMoBAvf2H0M4&m=s1rydy2wtTm4oNwi0LnpZYCnXrxxs7xi6nYvhktvqrw&s=uVv3yNkBzGPBbTo82Q8EhRnOB6xhe0NLTA_aK_-6WSM&e= >
>>
>> _______________________________________________
>> Halld-offline mailing list
>> Halld-offline at jlab.org
>> https://mailman.jlab.org/mailman/listinfo/halld-offline
>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__nam10.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fmailman.jlab.org-252Fmailman-252Flistinfo-252Fhalld-2Doffline-26data-3D02-257C01-257Crichard.t.jones-2540uconn.edu-257C27fd9227d73c4da2c00a08d7ec41b3d3-257C17f1a87e2a254eaab9df9d439034b080-257C0-257C0-257C637237639251856246-26sdata-3D0acpsNjdYzHIez-252BvBUDisiD6Sj8p6oM78XUE685C98I-253D-26reserved-3D0&d=DwIFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=Te_hCR4EUlJ6iCDYLJ8Viv2aDOR7D9ZZMoBAvf2H0M4&m=s1rydy2wtTm4oNwi0LnpZYCnXrxxs7xi6nYvhktvqrw&s=uVv3yNkBzGPBbTo82Q8EhRnOB6xhe0NLTA_aK_-6WSM&e= >
>
> _______________________________________________
> Halld-offline mailing list
> Halld-offline at jlab.org
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__nam10.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fmailman.jlab.org-252Fmailman-252Flistinfo-252Fhalld-2Doffline-26amp-3Bdata-3D02-257C01-257Crichard.t.jones-2540uconn.edu-257C27fd9227d73c4da2c00a08d7ec41b3d3-257C17f1a87e2a254eaab9df9d439034b080-257C0-257C0-257C637237639251886232-26amp-3Bsdata-3DdoNOCLzRPLj59h9l4LLjZ04WFccf2s7KPmLa0vXRHEs-253D-26amp-3Breserved-3D0&d=DwIFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=Te_hCR4EUlJ6iCDYLJ8Viv2aDOR7D9ZZMoBAvf2H0M4&m=s1rydy2wtTm4oNwi0LnpZYCnXrxxs7xi6nYvhktvqrw&s=6e6-OfuqOOge3abxyj5Vicwdfy_vI-t762D8-aTxNxY&e= 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.jlab.org/pipermail/halld-offline/attachments/20200429/d5e7c54f/attachment-0002.html>