[Dsg-hallc_controls] Current regulation loop

[Amanda Hoebel]

Mike, 

My answers are inline in blue. 

It appears that your expectation is not correct. 
I do not understand what you mean by expectation. 

I stopped reviewing the code when I found the following. 

Rung 0 
The MPS_WA_Value will always be greater than ADC_Readback_MPS 

The WA value is the PSU set value 0 to 100% or 0 to 999999 
The readback value is always a factor of 10 less. 

We checked the MPS_Commands portion of the PLC code and were unable to find the units for the MPS_WA_Value. We did not know the units for the current tags (I_True, I_Coarse, and ADC_Readback_MPS) and believed the tags were in the units of Amps. 

We had checked the newly developed PLC code (which uses Amps for the tags) with the Python code (developed by DSG) which simulates Danfysik power supply; the program executed correctly. We believe that the error in the original PLC program is due to the difference in units. We guess that the ADC_Readback is in ppm based on the conversion numbers used in the PLC program and on our knowledge of how other Danfysik power supplies work. 

Rung 2 
I_MOL is the current set value 0 to 3000 amps., it will never match the ADC readback. 

As mentioned above we were unclear about the units used. We are guessing ADC readback is in ppm, which is why, we think, you said I_MOL [Amps] will never match ADC readback [ppm] (Because different units are being used). 

Unknown, possible runaway, condition when there is an interlock, the PSU ramps down, operator resets the interlock, and restarts. 
What do you mean by "unknown, possible runaway, condition when there is an interlock, the PSU ramps down, operator resets the interlock, and restarts"? 

Cheers, 
Mike 

The current loop regulation is not a separate routine, but a modification to the existing routine which takes place in both the MPS_Commands ladder logic routine and the Q1/Q2/Q3 function block diagram; therefore, it is not possible to send you only what I added/modified. 
I can add these changes to a copy of the latest program and specify where the changes are located. 

Regards, 
Amanda 




----- Original Message ----- 
From: "Mike Fowler" <fowler at jlab.org> 
To: "Amanda Hoebel" <amandah at jlab.org> 
Cc: "dsg-hallc controls" <dsg-hallc_controls at jlab.org> 
Sent: Wednesday, August 1, 2018 10:29:53 AM 
Subject: Re: [Dsg-hallc_controls] Current regulation loop 

Hi, 

We need a copy of your code and only the changes you propose to make. 
The ADC file you modified is old and if loaded into the PLC it would cause operational problems. 
We need to be able to copy and paste your code into the running system, not replace the running system. 

Cheers, 
Mike 




----- Original Message ----- 
From: "Mike Fowler" <fowler at jlab.org> 
To: "Amanda Hoebel" <amandah at jlab.org> 
Cc: "dsg-hallc controls" <dsg-hallc_controls at jlab.org> 
Sent: Wednesday, August 1, 2018 9:02:16 AM 
Subject: Re: [Dsg-hallc_controls] Current regulation loop 

Hi, 

It appears that your expectation is not correct. 
I stopped reviewing the code when I found the following. 

Issues found: 

Rung 0 
The MPS_WA_Value will always be greater than ADC_Readback_MPS 

The WA value is the PSU set value 0 to 100% or 0 to 999999 
The readback value is always a factor of 10 less. 

Rung 2 
I_MOL is the current set value 0 to 3000 amps., it will never match the ADC readback. 

Unknown, possible runaway, condition when there is an interlock, the PSU ramps down, operator resets the interlock, and restarts. 

Cheers, 
Mike 




----- Original Message ----- 
From: "Amanda Hoebel" <amandah at jlab.org> 
To: "dsg-hallc controls" <dsg-hallc_controls at jlab.org> 
Sent: Monday, July 30, 2018 4:49:35 PM 
Subject: [Dsg-hallc_controls] Current regulation loop 

Hello Steve and Mike, 

Updated versions of the HMS and SHMS programs to include the current regulation loop are in the M: drive, "M:\dsg-hallc_controls\HMS_Controls_V20_current_loop.ACD" and "M:\dsg-hallc_controls\SHMS_V_20_current_loop.ACD". The program was tested using the DSG test PLC and a serial program to simulate the danfysik power supply. The program ran as expected and allowed the user to change setpoints mid-ramp without issue. 

Regards, 
Amanda 
_______________________________________________ 
Dsg-hallc_controls mailing list 
Dsg-hallc_controls at jlab.org 
https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls 
_______________________________________________ 
Dsg-hallc_controls mailing list 
Dsg-hallc_controls at jlab.org 
https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.jlab.org/pipermail/dsg-hallc_controls/attachments/20180806/0f3e2a0b/attachment.html>