[Dsg-hallc_controls] Dipole Field Regulation PLC code completed

[Pablo Campero]

Hi Mike, 

Find my answers to you comments in font blue below: 


NMR, Function Block : 

SEL_08.In1 has no input 
Having no input in the "In1" at "SEL_08" instruction is the same as having an input of zero value; RS-Logix5000 interprets PLC code in this way when there is no input wired to the instructions. Regardless, I added a zero as a constant input when NMR-PT2026 is not locked. 
At this time, the value for the field readout from the NMR-PT2026 unit when this is not locked is undetermined, since we did not have the chance to test it. 

TONR_05 has no reset input 
I removed timer "TONR_05" from routine. 
When filter is enabled manually from HMI screen for the first time, we will have to consider that the array set in filter will be fully populate after 60 sec; filter takes a readout once per second into an array of 60 elements to make a rolling average. "Number of samples,"array sizes", and "Frequency" are values that can be modified to change the settings of this filter, which is optional. 

Tag: Filter_On does not seem to be set anywhere in the code provided. 
"Filter_On" is a Boolean variable that can be controlled by operator from the HMI screen to enable or disable filtering option to the magnetic field readouts. 

Function Block, page #2: 
The TONR_07 has no input for the Reset. 
Reset for "TONR_07" added and tested. 

Ladder, rung 5 
T1_DN has no associated timer. 
Rungs 4, 5 and 6 were modified (See attachments) 



In addition to the comments above, please attached find the printouts of the PLC routines. 

Regards, 
Pablo 






From: "Mike Fowler" <fowler at jlab.org> 
To: "dsg-hallc controls" <dsg-hallc_controls at jlab.org> 
Sent: Tuesday, September 25, 2018 10:25:49 AM 
Subject: Re: [Dsg-hallc_controls] Dipole Field Regulation PLC code completed 


Additional comments. 

NMR function block 

SEL_08.In1 has no input 
TONR_05 has no reset input 
Tag: Filter_On does not seem to be set anywhere in the code provided. 

Mike 




On 9/25/2018 10:00 AM, Mike Fowler wrote: 



Hi, 

Comments on the code. 

Function Block, page #2 
The TONR_07 has no input for the Reset. 

Ladder, rung 5 
T1_DN has no associated timer. 

Cheers, 
Mike 





On 9/14/2018 6:16 PM, Pablo Campero wrote: 

BQ_BEGIN

Hello Mike, 

Attached find the pdfs with the Dipole Field Regulation PLC routines; comments are showed in each section of the routines. 

Best regards, 
Pablo 



_______________________________________________
Dsg-hallc_controls mailing list Dsg-hallc_controls at jlab.org https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls 







_______________________________________________
Dsg-hallc_controls mailing list Dsg-hallc_controls at jlab.org https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls 

BQ_END




_______________________________________________ 
Dsg-hallc_controls mailing list 
Dsg-hallc_controls at jlab.org 
https://mailman.jlab.org/mailman/listinfo/dsg-hallc_controls 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.jlab.org/pipermail/dsg-hallc_controls/attachments/20180926/b43e577f/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Dipole_Field_Regulation (Main Routine).pdf
Type: application/pdf
Size: 267159 bytes
Desc: not available
URL: <https://mailman.jlab.org/pipermail/dsg-hallc_controls/attachments/20180926/b43e577f/attachment-0003.pdf>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Calculate_DI_Current.pdf
Type: application/pdf
Size: 83529 bytes
Desc: not available
URL: <https://mailman.jlab.org/pipermail/dsg-hallc_controls/attachments/20180926/b43e577f/attachment-0004.pdf>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NMR_Read_B.pdf
Type: application/pdf
Size: 91037 bytes
Desc: not available
URL: <https://mailman.jlab.org/pipermail/dsg-hallc_controls/attachments/20180926/b43e577f/attachment-0005.pdf>